[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83927478 --- Diff: R/pkg/R/DataFrame.R --- @@ -1166,26 +1166,33 @@ setMethod("take", collect(limited) }) -#' Head -#'

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83927201 --- Diff: R/pkg/R/DataFrame.R --- @@ -1166,26 +1166,33 @@ setMethod("take", collect(limited) }) -#' Head -#'

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-18 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83926993 --- Diff: R/pkg/R/DataFrame.R --- @@ -1166,26 +1166,33 @@ setMethod("take", collect(limited) }) -#' Head -#'

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83353715 --- Diff: R/pkg/R/column.R --- @@ -70,11 +70,11 @@ setMethod("show", signature = "Column", function(object) { }) #' @rdname head -set

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-13 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83154700 --- Diff: R/pkg/R/column.R --- @@ -29,38 +31,61 @@ setOldClass("jobj") #' @rdname column #' #' @slot jc reference to JVM SparkDataFrame col

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-12 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r83057347 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad = "character"), setMethod("rand

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82919122 --- Diff: R/pkg/R/DataFrame.R --- @@ -1168,12 +1179,14 @@ setMethod("take", #' Head #' -#' Return the first \code{num} rows of a SparkDat

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82918200 --- Diff: R/pkg/R/column.R --- @@ -32,35 +34,57 @@ setOldClass("jobj") #' @export #' @note Column since 1.4.0 setClass("Column", -

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82911304 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad = "character"), setMethod("r

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82911261 --- Diff: R/pkg/R/DataFrame.R --- @@ -1049,11 +1055,16 @@ setMethod("dim", #' @export #' @examples #'\dontrun{ -#' sparkR.session() -#

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82911244 --- Diff: R/pkg/R/DataFrame.R --- @@ -1035,10 +1035,16 @@ setMethod("dim", c(count(x), ncol(x)) }) -#' Collects all

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread olarayej
Github user olarayej commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82910308 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad = "character"), setMethod("rand

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908836 --- Diff: R/pkg/R/functions.R --- @@ -3026,7 +3048,11 @@ setMethod("translate", setMethod("unix_timestamp", signature(x = "missing", format = "missin

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908811 --- Diff: R/pkg/R/functions.R --- @@ -2865,7 +2882,11 @@ setMethod("rand", signature(seed = "numeric"), setMethod("randn", signature(seed = "missing"

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908825 --- Diff: R/pkg/R/functions.R --- @@ -2876,7 +2897,8 @@ setMethod("randn", signature(seed = "missing"), setMethod("randn", signature(seed = "numeric"

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908799 --- Diff: R/pkg/R/functions.R --- @@ -2847,7 +2860,11 @@ setMethod("rand", signature(seed = "missing"), setMethod("rand", signature(seed = "numeric")

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908731 --- Diff: R/pkg/R/functions.R --- @@ -2836,7 +2845,11 @@ setMethod("lpad", signature(x = "Column", len = "numeric", pad = "character"), setMethod("r

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82908439 --- Diff: R/pkg/R/column.R --- @@ -32,35 +34,65 @@ setOldClass("jobj") #' @export #' @note Column since 1.4.0 setClass("Column", -

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82907977 --- Diff: R/pkg/R/DataFrame.R --- @@ -1168,12 +1179,14 @@ setMethod("take", #' Head #' -#' Return the first \code{num} rows of a Spark

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82907897 --- Diff: R/pkg/R/DataFrame.R --- @@ -1182,10 +1195,18 @@ setMethod("take", #' @export #' @examples #'\dontrun{ -#' sparkR.session()

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82907729 --- Diff: R/pkg/R/DataFrame.R --- @@ -1035,10 +1035,16 @@ setMethod("dim", c(count(x), ncol(x)) }) -#' Collects

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82888215 --- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R --- @@ -2252,6 +2252,31 @@ test_that("Method str()", { expect_equal(capture.output(utils:::str(iris)

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82887849 --- Diff: R/pkg/R/column.R --- @@ -32,35 +34,65 @@ setOldClass("jobj") #' @export #' @note Column since 1.4.0 setClass("Column", - s

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82888061 --- Diff: R/pkg/R/column.R --- @@ -32,35 +34,65 @@ setOldClass("jobj") #' @export #' @note Column since 1.4.0 setClass("Column", - s

[GitHub] spark pull request #11336: [SPARK-9325][SPARK-R] collect() head() and show()...

2016-10-11 Thread falaki
Github user falaki commented on a diff in the pull request: https://github.com/apache/spark/pull/11336#discussion_r82887445 --- Diff: R/pkg/R/DataFrame.R --- @@ -1035,10 +1035,17 @@ setMethod("dim", c(count(x), ncol(x)) }) -#' Collects all t