[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15414 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r83057213 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82988194 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82931901 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82932068 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -121,10 +122,18 @@ abstract class Predictor[ * and put it in an RDD with

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82935295 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82932894 --- Diff: mllib/src/test/scala/org/apache/spark/ml/PredictorSuite.scala --- @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user sethah commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82932799 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTestingUtils.scala --- @@ -117,7 +117,7 @@ object MLTestingUtils extends SparkFunSuite {

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user zhengruifeng commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82718401 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -121,10 +122,18 @@ abstract class Predictor[ * and put it in an RDD

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

Github user hhbyyh commented on a diff in the pull request: https://github.com/apache/spark/pull/15414#discussion_r82684098 --- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala --- @@ -121,10 +122,18 @@ abstract class Predictor[ * and put it in an RDD with

[GitHub] spark pull request #15414: [SPARK-17848][ML] Move LabelCol datatype cast int...

GitHub user zhengruifeng opened a pull request: https://github.com/apache/spark/pull/15414 [SPARK-17848][ML] Move LabelCol datatype cast into Predictor.fit ## What changes were proposed in this pull request? 1, move cast to `Predictor` 2, and then, remove unnecessary cast