[GitHub] spark pull request #15489: [SPARK-17863] [SQL] should not add column into Di...

2016-10-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/15489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request #15489: [SPARK-17863] [SQL] should not add column into Di...

2016-10-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15489#discussion_r83500257 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1106,6 +1106,30 @@ class SQLQuerySuite extends QueryTest with SharedSQLCont

[GitHub] spark pull request #15489: [SPARK-17863] [SQL] should not add column into Di...

2016-10-14 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/15489#discussion_r83495403 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1106,6 +1106,30 @@ class SQLQuerySuite extends QueryTest with SharedSQLCon

[GitHub] spark pull request #15489: [SPARK-17863] [SQL] should not add column into Di...

2016-10-14 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/15489#discussion_r83486321 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -1106,6 +1106,30 @@ class SQLQuerySuite extends QueryTest with SharedSQLCont

[GitHub] spark pull request #15489: [SPARK-17863] [SQL] should not add column into Di...

2016-10-14 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/15489 [SPARK-17863] [SQL] should not add column into Distinct ## What changes were proposed in this pull request? We are trying to resolve the attribute in sort by pulling up some column for gra