Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15929
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88827491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -452,15 +444,7 @@ case class EqualNullSafe(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88774814
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -452,15 +444,7 @@ case class EqualNullSafe(left:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88774467
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -481,8 +481,13 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88770432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -481,8 +481,13 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88764135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -481,8 +481,13 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88763155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -481,8 +481,13 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/15929#discussion_r88701973
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -512,6 +517,9 @@ class CodegenContext
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/15929
[SPARK-18053][SQL] compare unsafe and safe complex-type values correctly
## What changes were proposed in this pull request?
In Spark SQL, some expression may output safe format values,
