[GitHub] spark pull request #16106: [SPARK-17213][SQL] Disable Parquet filter push-do...

2016-12-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/16106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #16106: [SPARK-17213][SQL] Disable Parquet filter push-do...

2016-12-01 Thread liancheng
GitHub user liancheng opened a pull request:

https://github.com/apache/spark/pull/16106

[SPARK-17213][SQL] Disable Parquet filter push-down for string and binary 
columns due to PARQUET-686

## What changes were proposed in this pull request?

Due to PARQUET-686, Parquet doesn't do string comparison correctly while 
doing filter push-down for string columns. This PR disables filter push-down 
for both string and binary columns to work around this issue. Binary columns 
are also affected because some Parquet data models (like Hive) may store string 
columns as a plain Parquet `binary` instead of a `binary (UTF8)`.

## How was this patch tested?

New test case added in `ParquetFilterSuite`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liancheng/spark spark-17213-bad-string-ppd

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/16106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16106


commit d7162bfdb2a4389ea08cbb0d3627a429de6d7c45
Author: Cheng Lian 
Date:   2016-12-01T19:52:20Z

Add test case

commit 810c1533ae9ba959e9696a806b22e19f8d0b5c31
Author: Cheng Lian 
Date:   2016-12-01T19:54:09Z

Disable Parquet filter push-down for string and binary columns

commit ce71cca44009d2f8508e02291ac6872b680cd28a
Author: Cheng Lian 
Date:   2016-12-01T19:59:37Z

Test more string comparison operators




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org