Github user michaelkamprath closed the pull request at:
https://github.com/apache/spark/pull/16403
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94264691
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,18 @@ public static void throwException(Throwable t) {
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94259189
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -22,10 +22,14 @@
import java.lang.reflect.Method;
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94257179
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,18 @@ public static void throwException(Throwable t)
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94249364
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,18 @@ public static void throwException(Throwable t) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94215657
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -22,10 +22,14 @@
import java.lang.reflect.Method;
import
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94215787
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,74 @@ public void memoryDebugFillEnabledInTest() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94215274
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessFunctor.java ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94054024
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94053751
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessFunctor.java ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94049781
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94049706
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94049578
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -252,6 +272,7 @@ public static void throwException(Throwable t) {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94049023
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessFunctor.java ---
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94047852
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,19 @@ public static void throwException(Throwable t)
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94047799
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,19 @@ public static void throwException(Throwable t)
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94047695
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -44,6 +48,9 @@
public static final int
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94047557
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessDirect.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94047419
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessBuffered.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012502
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void memoryDebugFillEnabledInTest() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012317
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessDirect.java ---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012548
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void memoryDebugFillEnabledInTest() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012460
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -252,6 +272,7 @@ public static void throwException(Throwable t) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012274
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/DoubleAccessBuffered.java
---
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012361
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -44,6 +48,9 @@
public static final int DOUBLE_ARRAY_OFFSET;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012336
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,19 @@ public static void throwException(Throwable t) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012605
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -74,4 +76,71 @@ public void memoryDebugFillEnabledInTest() {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r94012446
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +251,19 @@ public static void throwException(Throwable t) {
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93983319
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +257,34 @@ public static void throwException(Throwable t)
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93982964
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -119,7 +127,12 @@ public static void putFloat(Object object, long
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93982937
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +257,34 @@ public static void throwException(Throwable t)
Github user michaelkamprath commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93982849
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -44,6 +49,9 @@
public static final int
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93979180
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +257,34 @@ public static void throwException(Throwable t) {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93979106
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -119,7 +127,12 @@ public static void putFloat(Object object, long
offset,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93968567
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -244,6 +257,34 @@ public static void throwException(Throwable t) {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93968471
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -44,6 +49,9 @@
public static final int DOUBLE_ARRAY_OFFSET;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16403#discussion_r93968508
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -119,7 +127,12 @@ public static void putFloat(Object object, long
offset,
GitHub user michaelkamprath opened a pull request:
https://github.com/apache/spark/pull/16403
[SPARK-18819][CORE] Double byte alignment on ARM platforms
## What changes were proposed in this pull request?
On 32-bit ARM platforms, doubles require 8-byte alignment. The use of
38 matches
Mail list logo
