[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16436#discussion_r94175562
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -219,6 +219,16 @@ class StringIndexerSuite
testDefaultReadWrite(t)
}
+ test("SPARK 18698: construct IndexToString with custom uid") {
+val uid = Identifiable.randomUID("customuid")
+val t = new IndexToString(uid)
+ .setInputCol("myInputCol")
--- End diff --
done, simplified test case based on comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16436#discussion_r94175568
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -219,6 +219,16 @@ class StringIndexerSuite
testDefaultReadWrite(t)
}
+ test("SPARK 18698: construct IndexToString with custom uid") {
+val uid = Identifiable.randomUID("customuid")
+val t = new IndexToString(uid)
+ .setInputCol("myInputCol")
--- End diff --
done, simplified test case based on comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16436#discussion_r94175547
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -219,6 +219,16 @@ class StringIndexerSuite
testDefaultReadWrite(t)
}
+ test("SPARK 18698: construct IndexToString with custom uid") {
+val uid = Identifiable.randomUID("customuid")
+val t = new IndexToString(uid)
+ .setInputCol("myInputCol")
--- End diff --
done, simplified test case based on comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #16436: [SPARK-18698][ML] Adding public constructor that ...
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16436#discussion_r94174966
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -219,6 +219,16 @@ class StringIndexerSuite
testDefaultReadWrite(t)
}
+ test("SPARK 18698: construct IndexToString with custom uid") {
+val uid = Identifiable.randomUID("customuid")
+val t = new IndexToString(uid)
+ .setInputCol("myInputCol")
--- End diff --
Sure, will update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
