Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96331626
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,60 @@ import org.apache.spark.sql.catalyst.rul
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96313495
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,60 @@ import org.apache.spark.sql.catalyst.rules.Rul
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16561
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96175295
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -89,6 +89,25 @@ object Cast {
case _ => false
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rul
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168416
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rul
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168283
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96168225
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96167779
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules
Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96159390
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -198,9 +203,44 @@ case class CatalogTable(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96158153
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/view.scala
---
@@ -28,22 +28,56 @@ import org.apache.spark.sql.catalyst.rules
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157931
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -680,21 +700,70 @@ class SQLViewSuite extends QueryTest wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157834
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLViewSuite.scala
---
@@ -680,21 +700,70 @@ class SQLViewSuite extends QueryTest wi
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -198,9 +203,44 @@ case class CatalogTable(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -198,9 +203,44 @@ case class CatalogTable(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157263
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -254,6 +294,9 @@ case class CatalogTable(
ob
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/16561#discussion_r96157156
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -198,9 +203,44 @@ case class CatalogTable(
18 matches
Mail list logo