Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/16607
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99263532
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +302,36 @@ class Word2VecModel private[ml] (
@Since("1.6.0")
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99263525
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +340,29 @@ object Word2VecModel extends
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r99259617
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -18,10 +18,9 @@
package org.apache.spark.ml.feature
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96672243
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +341,29 @@ object Word2VecModel extends
MLReadable[Word2VecModel] {
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96524580
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +341,29 @@ object Word2VecModel extends
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96328450
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +341,29 @@ object Word2VecModel extends
MLReadable[Word2VecModel] {
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96327575
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +303,36 @@ class Word2VecModel private[ml] (
@Since("1.6.0")
Github user Krimit commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96327379
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +303,36 @@ class Word2VecModel private[ml] (
@Since("1.6.0")
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96307400
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +341,29 @@ object Word2VecModel extends
MLReadable[Word2VecModel] {
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96307257
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +303,36 @@ class Word2VecModel private[ml] (
@Since("1.6.0")
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96307241
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -302,16 +303,36 @@ class Word2VecModel private[ml] (
@Since("1.6.0")
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16607#discussion_r96307444
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala
---
@@ -320,14 +341,29 @@ object Word2VecModel extends
MLReadable[Word2VecModel] {
13 matches
Mail list logo