[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/16896 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-03-06 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16896#discussion_r104601283 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-02-14 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/16896#discussion_r101204910 --- Diff: python/pyspark/sql/types.py --- @@ -189,7 +189,7 @@ def toInternal(self, dt): if dt is not None: seconds =

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-02-11 Thread JasonMWhite
Github user JasonMWhite commented on a diff in the pull request: https://github.com/apache/spark/pull/16896#discussion_r100681604 --- Diff: python/pyspark/sql/tests.py --- @@ -1435,6 +1435,12 @@ def test_time_with_timezone(self): self.assertEqual(now, now1)

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-02-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16896#discussion_r100680863 --- Diff: python/pyspark/sql/tests.py --- @@ -1435,6 +1435,12 @@ def test_time_with_timezone(self): self.assertEqual(now, now1)

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-02-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/16896#discussion_r100680623 --- Diff: python/pyspark/sql/tests.py --- @@ -1435,6 +1435,12 @@ def test_time_with_timezone(self): self.assertEqual(now, now1)

[GitHub] spark pull request #16896: [SPARK-19561][Python] cast TimestampType.toIntern...

2017-02-11 Thread JasonMWhite
GitHub user JasonMWhite opened a pull request: https://github.com/apache/spark/pull/16896 [SPARK-19561][Python] cast TimestampType.toInternal output to long ## What changes were proposed in this pull request? Cast the output of `TimestampType.toInternal` to long to allow