[GitHub] spark pull request #17628: [SPARK-20316][SQL] Val and Var should strictly fo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/17628


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17628: [SPARK-20316][SQL] val and var should strictly fo...

[viirya]

Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/17628#discussion_r111318807
  
--- Diff: 
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
 ---
@@ -47,8 +47,8 @@ import org.apache.spark.util.ShutdownHookManager
  * has dropped its support.
  */
 private[hive] object SparkSQLCLIDriver extends Logging {
-  private var prompt = "spark-sql"
-  private var continuedPrompt = "".padTo(prompt.length, ' ')
+  private val prompt = "spark-sql"
--- End diff --

This is very old code. Looks this change is okay. cc @liancheng


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17628: [SPARK-20316][SQL] val and var should strictly fo...

[ouyangxiaochen]

GitHub user ouyangxiaochen opened a pull request:

https://github.com/apache/spark/pull/17628

[SPARK-20316][SQL] val and var should strictly follow the Scala syntax

 What changes were proposed in this pull request?

val and var should strictly follow the Scala syntax

How was this patch tested?

manual test and exisiting test cases


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ouyangxiaochen/spark spark-413

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/17628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17628


commit 32b12a031b56b07b47d5ffb728038f82eb0cd597
Author: ouyangxiaochen 
Date:   2017-04-13T05:03:50Z

val and var should strictly follow the Scala syntax




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org