[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/17936 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117432268 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117429928 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117427240 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117426327 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117424810 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117425810 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117424223 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117423372 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,92 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-18 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117393923 --- Diff: core/src/test/scala/org/apache/spark/metrics/InputOutputMetricsSuite.scala --- @@ -198,8 +198,12 @@ class InputOutputMetricsSuite extends SparkFu

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-18 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r117393634 --- Diff: core/src/test/scala/org/apache/spark/metrics/InputOutputMetricsSuite.scala --- @@ -198,8 +198,12 @@ class InputOutputMetricsSuite extends SparkFu

[GitHub] spark pull request #17936: [SPARK-20638][Core]Optimize the CartesianRDD to r...

2017-05-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/17936#discussion_r116959739 --- Diff: core/src/main/scala/org/apache/spark/rdd/CartesianRDD.scala --- @@ -71,9 +72,85 @@ class CartesianRDD[T: ClassTag, U: ClassTag]( }