Github user wangyum closed the pull request at:
https://github.com/apache/spark/pull/18106
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r130837526
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r130833154
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
@since(1.5)
-def trunc(date,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r130801952
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r124329456
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r124328743
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,29 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123920115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123919660
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123884847
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,28 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123884830
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1382,8 +1382,8 @@ test_that("column functions", {
c20 <- to_timestamp(c) +
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123871837
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscExpressionsSuite.scala
---
@@ -44,4 +46,49 @@ class MiscExpressionsSuite
Github user wzhfy commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123871820
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/MiscExpressionsSuite.scala
---
@@ -44,4 +46,49 @@ class MiscExpressionsSuite
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123831200
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123831034
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123828403
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2067,6 +2067,18 @@ object functions {
*/
def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123828339
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2067,6 +2067,18 @@ object functions {
*/
def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123827347
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2067,6 +2067,18 @@ object functions {
*/
def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123824736
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,28 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123822928
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1382,8 +1382,8 @@ test_that("column functions", {
c20 <- to_timestamp(c) +
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123798230
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1382,8 +1382,8 @@ test_that("column functions", {
c20 <- to_timestamp(c) +
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123759792
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1382,8 +1382,8 @@ test_that("column functions", {
c20 <- to_timestamp(c) + to_timestamp(c,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123759339
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -1382,8 +1382,8 @@ test_that("column functions", {
c20 <- to_timestamp(c) +
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123758795
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123758531
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123757175
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123756528
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123755745
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123754453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123753748
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123752789
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,154 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123752317
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,28 @@ def to_timestamp(col, format=None):
@since(1.5)
-def trunc(date,
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123684235
--- Diff: python/pyspark/sql/functions.py ---
@@ -1028,20 +1028,28 @@ def to_timestamp(col, format=None):
@since(1.5)
-def
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123190922
--- Diff: sql/core/src/test/resources/sql-tests/inputs/operators.sql ---
@@ -92,3 +91,7 @@ select abs(-3.13), abs('-2.19');
-- positive/negative
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123161910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,141 @@ case class Uuid() extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18106#discussion_r123155483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala
---
@@ -132,3 +133,141 @@ case class Uuid() extends
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/18106
[SPARK-20754][SQL] Support TRUNC (number)
## What changes were proposed in this pull request?
Add support for `TRUNC(number)`, it's similar to Oracle
36 matches
Mail list logo
