[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/18318#discussion_r122378218
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(
 // direct property.
 val newTable = table.copy(
   properties = table.properties ++ properties,
-  comment = properties.get("comment"))
+  comment = properties.get("comment").orElse(table.comment))
--- End diff --

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[wzhfy]

Github user wzhfy commented on a diff in the pull request:

https://github.com/apache/spark/pull/18318#discussion_r122363898
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(
 // direct property.
 val newTable = table.copy(
   properties = table.properties ++ properties,
-  comment = properties.get("comment"))
+  comment = properties.get("comment").orElse(table.comment))
--- End diff --

alter table src set tblproperties ('foo' = 'bar', 'comment' = 
'table_comment');
alter table src unset tblproperties ('foo');
we will lost comment in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[gatorsmile]

Github user gatorsmile commented on a diff in the pull request:

https://github.com/apache/spark/pull/18318#discussion_r122359957
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(
 // direct property.
 val newTable = table.copy(
   properties = table.properties ++ properties,
-  comment = properties.get("comment"))
+  comment = properties.get("comment").orElse(table.comment))
--- End diff --

Could you show an example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/18318


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[viirya]

Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/18318#discussion_r122347115
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(
 // direct property.
 val newTable = table.copy(
   properties = table.properties ++ properties,
-  comment = properties.get("comment"))
+  comment = properties.get("comment").orElse(table.comment))
--- End diff --

This looks fine. However, when setting properties for Hive table, a `None` 
comment will be ignored and won't override the comment.

We don't do similar thing in `InMemoryCatalog` and just override it with 
the `None` comment.

Not sure if we should fix it here or in `InMemoryCatalog`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[wzhfy]

Github user wzhfy commented on a diff in the pull request:

https://github.com/apache/spark/pull/18318#discussion_r122334052
  
--- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
@@ -235,7 +235,7 @@ case class AlterTableSetPropertiesCommand(
 // direct property.
 val newTable = table.copy(
   properties = table.properties ++ properties,
-  comment = properties.get("comment"))
+  comment = properties.get("comment").orElse(table.comment))
--- End diff --

What about UNSET TBLPROPERTIES command?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #18318: [SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES...

[gatorsmile]

GitHub user gatorsmile opened a pull request:

https://github.com/apache/spark/pull/18318

[SPARK-21112] [SQL] ALTER TABLE SET TBLPROPERTIES should not overwrite 
COMMENT

### What changes were proposed in this pull request?
`ALTER TABLE SET TBLPROPERTIES` should not overwrite `COMMENT` even if the 
input property does not have the property of `COMMENT`. This PR is to fix the 
issue.

### How was this patch tested?
Covered by the existing tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gatorsmile/spark fixTableComment

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/18318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #18318


commit c697f9afdd5ee34d2c10376670fc2d1199039134
Author: Xiao Li 
Date:   2017-06-15T21:55:04Z

fix.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org