Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18599
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18599#discussion_r126847486
--- Diff: sbin/spark-daemon.sh ---
@@ -78,6 +78,12 @@ spark_rotate_log ()
if [ -n "$2" ]; then
num=$2
--- End diff --
Github user liu-zhaokun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18599#discussion_r126639515
--- Diff: sbin/spark-daemon.sh ---
@@ -78,6 +78,12 @@ spark_rotate_log ()
if [ -n "$2" ]; then
num=$2
fi
+
+expr
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18599#discussion_r126636677
--- Diff: sbin/spark-daemon.sh ---
@@ -78,6 +78,12 @@ spark_rotate_log ()
if [ -n "$2" ]; then
num=$2
fi
+
+expr $num +
GitHub user liu-zhaokun opened a pull request:
https://github.com/apache/spark/pull/18599
[SPARK-21372] spark writes one log file even I set the number of
spark_rotate_log to 0
[https://issues.apache.org/jira/browse/SPARK-21372](https://issues.apache.org/jira/browse/SPARK-21372)
