[GitHub] spark pull request #18635: [SPARK-21415] Triage scapegoat warnings, part 1

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18635#discussion_r127970648 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/CompactibleFileStreamLog.scala --- @@ -170,12 +170,8 @@ abstract class

[GitHub] spark pull request #18635: [SPARK-21415] Triage scapegoat warnings, part 1

Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/18635#discussion_r127970380 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DecimalSuite.scala --- @@ -109,8 +109,8 @@ class DecimalSuite extends SparkFunSuite with

[GitHub] spark pull request #18635: [SPARK-21415] Triage scapegoat warnings, part 1

Github user srowen closed the pull request at: https://github.com/apache/spark/pull/18635 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #18635: [SPARK-21415] Triage scapegoat warnings, part 1

GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/18635 [SPARK-21415] Triage scapegoat warnings, part 1 ## What changes were proposed in this pull request? Address scapegoat warnings for: - BigDecimal double constructor - Catching NPE