[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19340 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r162650427 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,112 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r162397198 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala --- @@ -149,4 +171,39 @@ object KMeansModel extends Loader[KMeansModel] {

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r162396652 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,111 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r162396772 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,111 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-18 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r162396979 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,111 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-14 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161398318 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161391180 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -573,44 +705,45 @@ object KMeans { } /** -

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-14 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161390943 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -573,44 +705,45 @@ object KMeans { } /** - *

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-14 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161390812 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -573,44 +705,45 @@ object KMeans { } /** -

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161385721 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,111 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161385643 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -573,44 +705,45 @@ object KMeans { } /** - *

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161380797 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379528 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379537 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379568 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala --- @@ -149,4 +173,38 @@ object KMeansModel extends Loader[KMeansModel] {

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379577 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2018-01-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r161379585 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +577,109 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-09-30 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r142006352 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-09-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r142001964 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -246,14 +271,16 @@ class KMeans private ( val

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-09-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r142001976 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }

[GitHub] spark pull request #19340: [SPARK-22119][ML] Add cosine distance to KMeans

2017-09-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/19340#discussion_r142001986 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeans.scala --- @@ -546,10 +574,88 @@ object KMeans { .run(data) }