Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19452
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144937226
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -221,43 +228,29 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144708446
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -349,14 +350,35 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144664962
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -349,12 +356,28 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144651101
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144620005
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala
---
@@ -0,0 +1,118 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144533029
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144532481
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144450136
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingSymmetricHashJoinHelperSuite.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r19963
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -161,6 +164,10 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r19650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -206,10 +213,19 @@ case class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r10844
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -161,6 +164,10 @@ case class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r10608
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -206,10 +213,19 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144437858
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,68 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144437488
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,68 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144437411
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -355,6 +362,8 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144437332
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -402,17 +411,27 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144437093
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -161,6 +164,10 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144436846
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -206,10 +213,19 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144436721
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -206,10 +213,19 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144436114
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -21,7 +21,7 @@ import
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144436075
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -127,12 +127,13 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144435919
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -127,12 +127,13 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144435689
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -221,43 +237,36 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144435539
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -221,43 +237,36 @@ case class
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144396781
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144372504
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -387,9 +400,10 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144371994
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user joseph-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144148695
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144128814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144131323
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -220,37 +232,36 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144128720
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144130110
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -127,12 +127,13 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r143879728
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144099476
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r143879599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r143807269
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144099311
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144097795
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144128285
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala
---
@@ -66,6 +67,60 @@ object
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/19452#discussion_r144132422
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala
---
@@ -355,12 +364,16 @@ case class
GitHub user joseph-torres opened a pull request:
https://github.com/apache/spark/pull/19452
[SPARK-22136][SS] Evaluate one-sided conditions early in stream-stream
joins.
## What changes were proposed in this pull request?
Evaluate one-sided conditions early in
42 matches
Mail list logo
