Github user WeichenXu123 closed the pull request at:
https://github.com/apache/spark/pull/19621
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r157169491
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,20 +80,49 @@ private[feature] trait StringIndexerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r157159460
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,20 +80,49 @@ private[feature] trait StringIndexerBase extends
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r157158872
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -79,20 +80,49 @@ private[feature] trait StringIndexerBase extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r152717925
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +160,49 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r152717985
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +160,49 @@ class StringIndexer @Since("1.4.0") (
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r152252491
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +160,49 @@ class StringIndexer @Since("1.4.0") (
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r152252553
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,69 +289,94 @@ class StringIndexerModel (
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r152252129
--- Diff: project/MimaExcludes.scala ---
@@ -82,7 +82,15 @@ object MimaExcludes {
// [SPARK-21087] CrossValidator, TrainValidationSplit
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r151344393
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,69 +289,94 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r151339193
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -177,7 +235,8 @@ object StringIndexer extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r151340844
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -217,69 +289,94 @@ class StringIndexerModel (
@Since("1.4.0")
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r151337906
--- Diff: project/MimaExcludes.scala ---
@@ -82,7 +82,15 @@ object MimaExcludes {
// [SPARK-21087] CrossValidator, TrainValidationSplit expose
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r151338923
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +160,49 @@ class StringIndexer @Since("1.4.0") (
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r148174902
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +152,33 @@ class StringIndexer @Since("1.4.0") (
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19621#discussion_r148172976
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -130,21 +152,33 @@ class StringIndexer @Since("1.4.0") (
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/19621
[SPARK-11215][ml] Add multiple columns support to StringIndexer
## What changes were proposed in this pull request?
Add multiple columns support to StringIndexer.
## How was
17 matches
Mail list logo
