Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19630
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151677913
--- Diff: python/pyspark/sql/functions.py ---
@@ -2049,132 +2050,12 @@ def map_values(col):
# User Defined
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151676061
--- Diff: python/pyspark/sql/functions.py ---
@@ -2049,132 +2050,12 @@ def map_values(col):
# User Defined Function
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151605217
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151605052
--- Diff: python/pyspark/sql/tests.py ---
@@ -3348,18 +3385,6 @@ def test_vectorized_udf_null_string(self):
res =
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151605081
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151524338
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151524279
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151523879
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151493167
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151489959
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,92 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151476420
--- Diff: python/pyspark/sql/functions.py ---
@@ -2208,26 +2089,39 @@ def udf(f=None, returnType=StringType()):
| 8| JOHN DOE|
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151476372
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -34,9 +34,11 @@ import org.apache.spark.util._
*/
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151476197
--- Diff: python/pyspark/rdd.py ---
@@ -56,6 +56,20 @@
__all__ = ["RDD"]
+class PythonEvalType(object):
+"""
+
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151476071
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,88 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151475971
--- Diff: python/pyspark/sql/udf.py ---
@@ -0,0 +1,155 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151466298
--- Diff: python/pyspark/worker.py ---
@@ -89,6 +90,26 @@ def verify_result_length(*a):
return lambda *a: (verify_result_length(*a),
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151448531
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -137,15 +138,18 @@ object ExtractPythonUDFs
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151448145
--- Diff: python/pyspark/rdd.py ---
@@ -56,6 +56,20 @@
__all__ = ["RDD"]
+class PythonEvalType(object):
+"""
+
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151448212
--- Diff: python/pyspark/sql/functions.py ---
@@ -2208,26 +2089,39 @@ def udf(f=None, returnType=StringType()):
| 8| JOHN DOE|
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151448056
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -34,9 +34,11 @@ import org.apache.spark.util._
*/
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151447943
--- Diff: python/pyspark/worker.py ---
@@ -89,6 +90,26 @@ def verify_result_length(*a):
return lambda *a: (verify_result_length(*a),
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151399050
--- Diff: python/pyspark/sql/group.py ---
@@ -214,15 +214,15 @@ def apply(self, udf):
:param udf: A function object returned by
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151393292
--- Diff: python/pyspark/sql/group.py ---
@@ -214,15 +214,15 @@ def apply(self, udf):
:param udf: A function object returned by
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151382381
--- Diff: python/pyspark/sql/group.py ---
@@ -214,15 +214,15 @@ def apply(self, udf):
:param udf: A function object returned by
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151381238
--- Diff: python/pyspark/sql/udf.py ---
@@ -0,0 +1,155 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151381770
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,88 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151377854
--- Diff: python/pyspark/sql/tests.py ---
@@ -3166,6 +3166,88 @@ def test_filtered_frame(self):
self.assertTrue(pdf.empty)
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151377556
--- Diff: python/pyspark/sql/functions.py ---
@@ -2271,15 +2169,42 @@ def pandas_udf(f=None, returnType=StringType()):
| 2|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151333004
--- Diff: python/pyspark/sql/functions.py ---
@@ -2208,26 +2089,39 @@ def udf(f=None, returnType=StringType()):
| 8| JOHN DOE|
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151335091
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala
---
@@ -137,15 +138,18 @@ object ExtractPythonUDFs extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151333227
--- Diff: python/pyspark/rdd.py ---
@@ -56,6 +56,20 @@
__all__ = ["RDD"]
+class PythonEvalType(object):
+"""
+Evaluation
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151332296
--- Diff:
core/src/main/scala/org/apache/spark/api/python/PythonRunner.scala ---
@@ -34,9 +34,11 @@ import org.apache.spark.util._
*/
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151333891
--- Diff: python/pyspark/sql/functions.py ---
@@ -2208,26 +2089,39 @@ def udf(f=None, returnType=StringType()):
| 8| JOHN DOE|
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19630#discussion_r151331041
--- Diff: python/pyspark/worker.py ---
@@ -89,6 +90,26 @@ def verify_result_length(*a):
return lambda *a: (verify_result_length(*a),
35 matches
Mail list logo
