[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19656 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-04 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19656#discussion_r148934478 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -213,19 +213,32 @@ trait CodegenSupport extends

[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19656#discussion_r148933507 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala --- @@ -76,6 +76,20 @@ case class BroadcastHashJoinExec(

[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-04 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/19656#discussion_r148933391 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -213,19 +213,32 @@ trait CodegenSupport extends

[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19656#discussion_r148917096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -213,19 +213,32 @@ trait CodegenSupport extends

[GitHub] spark pull request #19656: [SPARK-22445][SQL] move CodegenContext.copyResult...

2017-11-03 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/19656 [SPARK-22445][SQL] move CodegenContext.copyResult to CodegenSupport ## What changes were proposed in this pull request? `CodegenContext.copyResult` is kind of a global status for whole