Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19715
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r158347717
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -386,19 +382,16 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r158239692
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -386,19 +382,16 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157282154
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157156875
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157156926
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157158204
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157156113
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157156164
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +147,258 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r157158481
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +155,96 @@ final class QuantileDiscretizer
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156442207
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -107,11 +107,11 @@ private[feature] trait
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156356881
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -107,11 +107,11 @@ private[feature] trait
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156323615
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -168,20 +168,13 @@ final class QuantileDiscretizer
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156160532
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +156,102 @@ final class QuantileDiscretizer
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r156010806
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +156,102 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r155744727
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +156,106 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r154571718
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -105,9 +107,11 @@ private[feature] trait QuantileDiscretizerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r155759105
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +156,106 @@ final class QuantileDiscretizer
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r154133181
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,119 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153774332
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153776672
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,119 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153786414
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,166 @@ class QuantileDiscretizerSuite
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153774170
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153775090
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -86,6 +104,10 @@ private[feature] trait QuantileDiscretizerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153785692
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,119 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153772861
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,119 @@ final class QuantileDiscretizer
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153775451
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -50,10 +50,26 @@ private[feature] trait QuantileDiscretizerBase
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r153772930
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,119 @@ final class QuantileDiscretizer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150518031
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150451065
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450334
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450305
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450319
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450280
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450222
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,95 @@ final class QuantileDiscretizer
Github user huaxingao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150450151
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -104,7 +126,8 @@ private[feature] trait
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401598
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -104,7 +126,8 @@ private[feature] trait QuantileDiscretizerBase
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401672
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/QuantileDiscretizer.scala ---
@@ -129,34 +152,95 @@ final class QuantileDiscretizer
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401768
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401807
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150404292
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401744
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19715#discussion_r150401804
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -146,4 +146,172 @@ class QuantileDiscretizerSuite
GitHub user huaxingao opened a pull request:
https://github.com/apache/spark/pull/19715
[SPARK-22397][ML]add multiple columns support to QuantileDiscretizer
## What changes were proposed in this pull request?
add multi columns support to QuantileDiscretizer
## How was
44 matches
Mail list logo
