[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19902 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155394195 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389433 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389363 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389404 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,23 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155389138 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,22 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155388109 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,41 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread skambha
Github user skambha commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155387973 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,22 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155387709 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,41 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-06 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19902#discussion_r155225855 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/DataSourceV2Options.java --- @@ -49,4 +49,22 @@ public DataSourceV2Options(Map

[GitHub] spark pull request #19902: [SPARK-22452][SQL]Add getInt, getLong, getBoolean...

2017-12-05 Thread skambha
GitHub user skambha opened a pull request: https://github.com/apache/spark/pull/19902 [SPARK-22452][SQL]Add getInt, getLong, getBoolean to DataSourceV2Options - Implemented methods getInt, getLong, getBoolean for DataSourceV2Options - Added new unit tests to exercise these