[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20016 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157941778 --- Diff: examples/src/main/scala/org/apache/spark/examples/HdfsTest.scala --- @@ -39,7 +39,7 @@ object HdfsTest { val start =

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157941813 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala --- @@ -100,7 +100,7 @@ object SparkALS { ITERATIONS =

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157816044 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalALS.scala --- @@ -95,7 +95,7 @@ object LocalALS { def showWarning() {

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157794109 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -127,11 +125,11 @@ object DFSReadWriteTest {

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157941808 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala --- @@ -80,7 +80,7 @@ object SparkALS { def showWarning() {

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157816026 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -49,12 +49,10 @@ object DFSReadWriteTest { }

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-20 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157794196 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalFileLR.scala --- @@ -58,10 +58,10 @@ object LocalFileLR { // Initialize

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157925500 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala --- @@ -80,7 +80,7 @@ object SparkALS { def showWarning() {

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157925520 --- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala --- @@ -100,7 +100,7 @@ object SparkALS { ITERATIONS =

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157925457 --- Diff: examples/src/main/scala/org/apache/spark/examples/HdfsTest.scala --- @@ -39,7 +39,7 @@ object HdfsTest { val start =

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157810171 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalALS.scala --- @@ -95,7 +95,7 @@ object LocalALS { def showWarning() {

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157809630 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -49,12 +49,10 @@ object DFSReadWriteTest { }

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157793283 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -97,22 +95,22 @@ object DFSReadWriteTest { def

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread chetkhatri
Github user chetkhatri commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157792884 --- Diff: examples/src/main/scala/org/apache/spark/examples/BroadcastTest.scala --- @@ -42,7 +42,7 @@ object BroadcastTest { val arr1 = (0

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread markhamstra
Github user markhamstra commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157790330 --- Diff: examples/src/main/scala/org/apache/spark/examples/BroadcastTest.scala --- @@ -42,7 +42,7 @@ object BroadcastTest { val arr1 = (0

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157756696 --- Diff: examples/src/main/scala/org/apache/spark/examples/LocalFileLR.scala --- @@ -58,10 +58,10 @@ object LocalFileLR { // Initialize w to

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157756545 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -127,11 +125,11 @@ object DFSReadWriteTest { spark.stop()

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-19 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20016#discussion_r157756418 --- Diff: examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala --- @@ -97,22 +95,22 @@ object DFSReadWriteTest { def main(args:

[GitHub] spark pull request #20016: SPARK-22830 Scala Coding style has been improved ...

2017-12-18 Thread chetkhatri
GitHub user chetkhatri opened a pull request: https://github.com/apache/spark/pull/20016 SPARK-22830 Scala Coding style has been improved in Spark Examples ## What changes were proposed in this pull request? * Under Spark Scala Examples: Some of the syntax were written like