Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20495
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r166358420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1655,15 +1655,17 @@ case class Left(str: Exp
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r166205775
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1655,15 +1655,17 @@ case class Left(str:
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r166196777
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1655,15 +1655,17 @@ case class Left(str
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r165928335
--- Diff: python/pyspark/sql/functions.py ---
@@ -1705,10 +1705,12 @@ def unhex(col):
@ignore_unicode_prefix
@since(1.5)
def length(col):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r165855729
--- Diff: python/pyspark/sql/functions.py ---
@@ -1705,10 +1705,12 @@ def unhex(col):
@ignore_unicode_prefix
@since(1.5)
def length(col):
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r165854982
--- Diff: python/pyspark/sql/functions.py ---
@@ -1705,10 +1705,12 @@ def unhex(col):
@ignore_unicode_prefix
@since(1.5)
def length(col):
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r165855003
--- Diff: python/pyspark/sql/functions.py ---
@@ -1705,10 +1705,12 @@ def unhex(col):
@ignore_unicode_prefix
@since(1.5)
def length(col):
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20495#discussion_r165821762
--- Diff: python/pyspark/sql/functions.py ---
@@ -1705,10 +1705,12 @@ def unhex(col):
@ignore_unicode_prefix
@since(1.5)
def length(col):