[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-29 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205986079 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@ -0,0

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-27 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205932789 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-27 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205849187 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@ -0,0

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205752304 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-27 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205721972 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala --- @@ -0,0

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21748 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-25 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205178769 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala --- @@ -35,26 +35,39 @@

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-25 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205178092 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,45 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-25 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r205177861 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,45 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204635755 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,45 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204635584 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,45 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-24 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204636048 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala --- @@ -35,26 +35,39

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204140632 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204139176 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204138506 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204139679 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204139065 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-20 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r204139975 --- Diff: docs/running-on-kubernetes.md --- @@ -129,20 +129,27 @@ Spark executors must be able to connect to the Spark driver over a hostname and

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202802089 --- Diff: docs/running-on-kubernetes.md --- @@ -120,8 +120,8 @@ This URI is the location of the example jar that is already in the Docker image. ##

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202801155 --- Diff: docs/running-on-kubernetes.md --- @@ -120,8 +120,8 @@ This URI is the location of the example jar that is already in the Docker image. ##

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202782024 --- Diff: docs/running-on-kubernetes.md --- @@ -120,8 +120,8 @@ This URI is the location of the example jar that is already in the Docker image. ##

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202781388 --- Diff: docs/running-on-kubernetes.md --- @@ -603,8 +603,8 @@ specific to Spark on Kubernetes. Name of the driver pod. In cluster mode, if

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202772018 --- Diff: docs/running-on-kubernetes.md --- @@ -399,18 +426,18 @@ specific to Spark on Kubernetes. Path to the CA cert file for connecting

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202754673 --- Diff: docs/running-on-kubernetes.md --- @@ -486,7 +516,48 @@ specific to Spark on Kubernetes. Service account that is used when

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202753060 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala --- @@ -35,26 +35,39

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202754518 --- Diff: docs/running-on-kubernetes.md --- @@ -529,8 +600,11 @@ specific to Spark on Kubernetes. spark.kubernetes.driver.pod.name (none)

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-16 Thread liyinan926
Github user liyinan926 commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202752192 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,37 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202535016 --- Diff: docs/running-on-kubernetes.md --- @@ -117,6 +117,37 @@ If the local proxy is running at localhost:8001, `--master k8s://http://127.0.0.

[GitHub] spark pull request #21748: [SPARK-23146][K8S] Support client mode.

2018-07-15 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21748#discussion_r202534636 --- Diff: docs/running-on-kubernetes.md --- @@ -399,18 +426,18 @@ specific to Spark on Kubernetes. Path to the CA cert file for