[GitHub] spark pull request #22294: [SPARK-25287][INFRA] Add up-front check for JIRA_...

2018-08-30 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22294


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22294: [SPARK-25287][INFRA] Add up-front check for JIRA_...

2018-08-30 Thread erikerlandson
GitHub user erikerlandson opened a pull request:

https://github.com/apache/spark/pull/22294

[SPARK-25287][INFRA] Add up-front check for JIRA_USERNAME and JIRA_PASSWORD

## What changes were proposed in this pull request?

Add an up-front check that `JIRA_USERNAME` and `JIRA_PASSWORD` have been 
set. If they haven't, ask user if they want to continue. This prevents the JIRA 
state update from failing at the very end of the process because user forgot to 
set these environment variables.

## How was this patch tested?

I ran the script with environment vars set, and unset, to verify it works 
as specified.

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erikerlandson/spark spark-25287

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22294


commit 1ed41ddc922cd07f6d6c2384c5aa248699f9ef87
Author: Erik Erlandson 
Date:   2018-08-30T21:52:29Z

[SPARK-25287][INFRA] Add up-front check for JIRA_USERNAME and JIRA_PASSWORD




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org