[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-25 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22383


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-13 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/22383#discussion_r224964998
  
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,8 @@ object MimaExcludes {
 
   // Exclude rules for 3.0.x
   lazy val v30excludes = v24excludes ++ Seq(
+// [SPARK-25362][JavaAPI] Replace Spark Optional class with Java 
Optional
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
--- End diff --

Ah, this has to have a comma after it, and the line that was moved to the 
end needs the comma removed


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-13 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/22383#discussion_r224965080
  
--- Diff: project/MimaExcludes.scala ---
@@ -36,9 +36,11 @@ object MimaExcludes {
 
   // Exclude rules for 3.0.x
   lazy val v30excludes = v24excludes ++ Seq(
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.io.SnappyCompressionCodec.version"),
+// [SPARK-25362][JavaAPI] Replace Spark Optional class with Java 
Optional
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.api.java.JavaPairRDD.flatMapValues"),
--- End diff --

I realize that I neglected to leave comments in the lines above about the 
source of these exclusions in earlier changes. While you're here, could you add 
above this line: 

`// [SPARK-19287] JavaPairRDD flatMapValues requires function returning 
Iterable, not Iterator`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-13 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/22383#discussion_r224965113
  
--- Diff: project/MimaExcludes.scala ---
@@ -36,9 +36,11 @@ object MimaExcludes {
 
   // Exclude rules for 3.0.x
   lazy val v30excludes = v24excludes ++ Seq(
-
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.io.SnappyCompressionCodec.version"),
+// [SPARK-25362][JavaAPI] Replace Spark Optional class with Java 
Optional
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.api.java.JavaPairRDD.flatMapValues"),
 
ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.apache.spark.streaming.api.java.JavaPairDStream.flatMapValues")
+
ProblemFilters.exclude[DirectMissingMethodProblem]("org.apache.spark.io.SnappyCompressionCodec.version"),
--- End diff --

And above the line here, add
`// [SPARK-24109] Remove class SnappyOutputStreamWrapper`


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-12 Thread mmolimar 
Github user mmolimar commented on a diff in the pull request:

https://github.com/apache/spark/pull/22383#discussion_r224948273
  
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,8 @@ object MimaExcludes {
 
   // Exclude rules for 3.0.x
   lazy val v30excludes = v24excludes ++ Seq(
+// [SPARK-25362][JavaAPI] Replace Spark Optional class with Java 
Optional
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
--- End diff --

No worries. Done ;-)


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22383: [SPARK-25362][JavaAPI] Replace Spark Optional cla...

2018-10-12 Thread srowen 
Github user srowen commented on a diff in the pull request:

https://github.com/apache/spark/pull/22383#discussion_r224866566
  
--- Diff: project/MimaExcludes.scala ---
@@ -36,6 +36,8 @@ object MimaExcludes {
 
   // Exclude rules for 3.0.x
   lazy val v30excludes = v24excludes ++ Seq(
+// [SPARK-25362][JavaAPI] Replace Spark Optional class with Java 
Optional
+
ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.api.java.Optional")
--- End diff --

Sorry @mmolimar this needs a rebase; another change just added a line here 
and it conflicts. Otherwise looking good


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org