GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/22508
[SPARK-23549][SQL] Rename config
spark.sql.legacy.compareDateTimestampInTimestamp
## What changes were proposed in this pull request?
See title.
## How was this patch tested?
Make sure all references have been updated:
```
> git grep compareDateTimestampInTimestamp
docs/sql-programming-guide.md: - Since Spark 2.4, Spark compares a DATE
type with a TIMESTAMP type after promotes both sides to TIMESTAMP. To set
`false` to `spark.sql.legacy.compareDateTimestampInTimestamp` restores the
previous behavior. This option will be removed in Spark 3.0.
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
// if conf.compareDateTimestampInTimestamp is true
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
=> if (conf.compareDateTimestampInTimestamp) Some(TimestampType) else
Some(StringType)
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
=> if (conf.compareDateTimestampInTimestamp) Some(TimestampType) else
Some(StringType)
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
buildConf("spark.sql.legacy.compareDateTimestampInTimestamp")
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
def compareDateTimestampInTimestamp : Boolean =
getConf(COMPARE_DATE_TIMESTAMP_IN_TIMESTAMP)
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala:
"spark.sql.legacy.compareDateTimestampInTimestamp" ->
convertToTS.toString) {
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark SPARK-23549
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22508
commit f29dd8905f0b14c937a47d7abe291828c7de48b9
Author: Reynold Xin
Date: 2018-09-21T02:00:59Z
[SPARK-23549][SQL] Rename config
spark.sql.legacy.compareDateTimestampInTimestamp
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
