[GitHub] spark pull request #22856: [SPARK-25856][SQL][MINOR] Remove AverageLike and ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/22856


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22856: [SPARK-25856][SQL][MINOR] Remove AverageLike and ...

[dongjoon-hyun]

Github user dongjoon-hyun commented on a diff in the pull request:

https://github.com/apache/spark/pull/22856#discussion_r228771390
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Average.scala
 ---
@@ -23,9 +23,21 @@ import org.apache.spark.sql.catalyst.expressions._
 import org.apache.spark.sql.catalyst.util.TypeUtils
 import org.apache.spark.sql.types._
 
-abstract class AverageLike(child: Expression) extends DeclarativeAggregate 
{
--- End diff --

+1 for cleaning up this.
cc @mgaido91 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22856: [SPARK-25856][SQL][MINOR] Remove AverageLike and ...

[dilipbiswal]

GitHub user dilipbiswal opened a pull request:

https://github.com/apache/spark/pull/22856

[SPARK-25856][SQL][MINOR] Remove AverageLike and CountLike classes

## What changes were proposed in this pull request?
These two classes were added for regr_ expression support (SPARK-23907). 
These have been removed and hence we can remove these base classes and inline 
the logic in the concrete classes.
## How was this patch tested?
Existing tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dilipbiswal/spark average_cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22856


commit 6becdd55e173bca40943e2aafda6a49cf5eb9934
Author: Dilip Biswal 
Date:   2018-10-26T20:28:20Z

[SPARK-25856] Remove AverageLike and CountLike classes




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org