[GitHub] spark pull request #22899: [SPARK-25573] Combine resolveExpression and resol...

2018-12-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22899 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22899: [SPARK-25573] Combine resolveExpression and resol...

2018-12-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22899#discussion_r238483571 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -880,21 +880,38 @@ class Analyzer( }

[GitHub] spark pull request #22899: [SPARK-25573] Combine resolveExpression and resol...

2018-10-31 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22899#discussion_r229609343 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1051,30 +1034,65 @@ class Analyzer(

[GitHub] spark pull request #22899: [SPARK-25573] Combine resolveExpression and resol...

2018-10-31 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22899#discussion_r229608676 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -1051,30 +1034,65 @@ class Analyzer(

[GitHub] spark pull request #22899: [SPARK-25573] Combine resolveExpression and resol...

2018-10-31 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/22899 [SPARK-25573] Combine resolveExpression and resolve in the Analyzer ## What changes were proposed in this pull request? Currently in the Analyzer, we have two methods 1) Resolve