[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-12-02 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23146#discussion_r238104839 --- Diff: mllib/src/main/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularization.scala --- @@ -82,7 +82,72 @@ private[ml] class L2Regularization(

[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23146#discussion_r237888294 --- Diff: mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala --- @@ -16,9 +16,13 @@ */ package

[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23146#discussion_r237888645 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -250,6 +250,66 @@ private[classification] trait

[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23146#discussion_r237888349 --- Diff: mllib/src/test/scala/org/apache/spark/ml/optim/loss/DifferentiableRegularizationSuite.scala --- @@ -16,9 +16,13 @@ */ package

[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-11-30 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23146#discussion_r237888585 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -250,6 +250,66 @@ private[classification] trait

[GitHub] spark pull request #23146: [SPARK-26173] [MLlib] Prior regularization for Lo...

2018-11-26 Thread elfausto
GitHub user elfausto opened a pull request: https://github.com/apache/spark/pull/23146 [SPARK-26173] [MLlib] Prior regularization for Logistic Regression Implementation of [SPARK-26173](https://issues.apache.org/jira/browse/SPARK-26173). Unit tests have been added to the