[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r240022921 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239990434 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala --- @@ -16,10 +16,13

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239944338 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -380,6 +400,12 @@ private[spark] class SecurityManager( } }

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239898432 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -380,6 +400,12 @@ private[spark] class SecurityManager( } }

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239899856 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -112,12 +112,14 @@

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r23991 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite with

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900712 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -24,7 +24,7 @@ import

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239897958 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -367,11 +372,26 @@ private[spark] class SecurityManager( case _

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900460 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala --- @@ -158,6 +161,25

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239900826 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -18,8 +18,11 @@ package org.apache.spark import

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239884995 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite with

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239706529 --- Diff: resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala --- @@ -16,10

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239705869 --- Diff: core/src/test/scala/org/apache/spark/SecurityManagerSuite.scala --- @@ -440,12 +473,27 @@ class SecurityManagerSuite extends SparkFunSuite

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/23252#discussion_r239701821 --- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala --- @@ -367,11 +372,26 @@ private[spark] class SecurityManager( case _

[GitHub] spark pull request #23252: [SPARK-26239] File-based secret key loading for S...

GitHub user mccheah opened a pull request: https://github.com/apache/spark/pull/23252 [SPARK-26239] File-based secret key loading for SASL. ## What changes were proposed in this pull request? This proposes an alternative way to load secret keys into a Spark application