Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

cloud-fan closed pull request #45791: [SPARK-47567][SQL] Support LOCATE function to work with collated strings URL: https://github.com/apache/spark/pull/45791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2082250288 jenkins merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

cloud-fan commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2082251045 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

stevomitric commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2082204032 +1 LGTM, photon checks will be handled in this pr https://github.com/databricks/runtime/pull/91246 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

mihailom-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1565315128 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala: ## @@ -47,7 +47,7 @@ object CollationTypeCasts extends

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2049813115 heads up: we’ve done some major code restructuring in https://github.com/apache/spark/pull/45978, so please sync these changes before moving on @miland-db you’ll likely need to

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555471879 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555445740 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

cloud-fan commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555443148 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

dbatomic commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555425477 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

dbatomic commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555419431 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555419316 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

dbatomic commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1555413439 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,31 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1551491749 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,29 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1551446372 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -176,15 +176,29 @@ public Collation( */ public static

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549419320 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -835,6 +835,24 @@ public int indexOf(UTF8String v, int start) { return -1;

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549415554 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549406709 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549406709 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549407322 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549409185 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549406709 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549329172 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549324690 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

stefankandic commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549319915 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

stefankandic commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1549312876 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -179,12 +179,26 @@ public static StringSearch getStringSearch(

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2033971213 Adding Belgrade collation crew: @stefankandic @mihailom-db @nikolamand-db @dbatomic Adding: @cloud-fan & @MaxGekk -- This is an automated message from the Apache Git Service. To

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1546515865 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -835,6 +835,28 @@ public int indexOf(UTF8String v, int start) { return -1;

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1546515865 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -835,6 +835,28 @@ public int indexOf(UTF8String v, int start) { return -1;

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1546340273 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -1476,9 +1476,11 @@ case class StringLocate(substr: Expression,

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

uros-db commented on code in PR #45791: URL: https://github.com/apache/spark/pull/45791#discussion_r1546339255 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ## @@ -1498,14 +1500,15 @@ case class StringLocate(substr:

Re: [PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db commented on PR #45791: URL: https://github.com/apache/spark/pull/45791#issuecomment-2029685535 Adding @uros-db -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [SPARK-47567][SQL] Support LOCATE function to work with collated strings [spark]

miland-db opened a new pull request, #45791: URL: https://github.com/apache/spark/pull/45791 ### What changes were proposed in this pull request? Extend built-in string functions to support non-binary, non-lowercase collation for: locate ### Why are the changes needed? Update