Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
> On April 12, 2016, 4:39 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java, > > line 113 > > > > > > This doesnt seem to be used

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Matt
> On March 2, 2016, 1:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On March 2, 2016, 6:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/default_stack_advisor.py, line 35 > > > > > > Please include Srimanth Gunturi in the code review, thanks! > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On March 2, 2016, 9:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 46100: Support option to not create a version definition resource but return the structured JSON only

2016-04-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46100/ --- (Updated April 12, 2016, 12:55 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/#review128475 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On April 5, 2016, 5:32 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/service_advisor_BIGTOP08GANGLIA.py, > > line 1 > > > > > > Naming each service_advisor

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On March 2, 2016, 4:56 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 1 > > > > > > If I were to add HAWQ 2.0.0's metainfo.xml under HDP 2.3 stack,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On April 5, 2016, 7:53 p.m., Srimanth Gunturi wrote: > > Tim, thanks for contributing to the stack-advisor feature. > > > > When we started the stack-advisor feature, there was a lot of interconnect > > between base service component-layout and configurations (HDFS, YARN, > > MapReduce,

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128450 ---

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
> On April 12, 2016, 4:25 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java, > > line 188 > > > > > > Can we file JIRAs for the TODOs? Hi Jayush,

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128465 --- Ship it! Ship It! - Jayush Luniya On April 12, 2016, 4:27

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128457 ---

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Oliver Szabo
> On April 11, 2016, 5:14 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml, > > line 35 > > > > > > We now support

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 12, 2016, 5:33 p.m.) Review request for Ambari, Sumit Mohanty,

Review Request 46105: capacity-scheduler config blob is not a part of recommendation API when Hive Interactive query is turned ON

2016-04-12 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46105/ --- Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako.

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

2016-04-12 Thread Tim Thorpe
> On March 2, 2016, 9:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 46062: PXF service check must occur only after PXF is started

2016-04-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46062/#review128486 --- Ship it! Ship It! - Jayush Luniya On April 11, 2016, 11:23

Re: Review Request 46100: Support option to not create a version definition resource but return the structured JSON only

2016-04-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46100/#review128489 --- Ship it! Ship It! - Alejandro Fernandez On April 12, 2016,

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/ --- (Updated April 12, 2016, 7:12 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46105: capacity-scheduler config blob is not a part of recommendation API when Hive Interactive query is turned ON

2016-04-12 Thread Srimanth Gunturi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46105/#review128492 --- Ship it! Ship It! - Srimanth Gunturi On April 12, 2016,

Re: Review Request 43927: Add support for bulk delete host API

2016-04-12 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43927/ --- (Updated April 12, 2016, 6:37 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46105: capacity-scheduler config blob is not a part of recommendation API when Hive Interactive query is turned ON

2016-04-12 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46105/#review128500 --- Ship it! Ship It! - Swapan Shridhar On April 12, 2016, 6:03

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
> On April 12, 2016, 6:30 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java, > > line 56 > > > > > > Can we remove the default

Re: Review Request 43926: Frameworks support for bulk delete API

2016-04-12 Thread Ajit Kumar
> On April 12, 2016, 3:41 p.m., Nate Cole wrote: > > What is the status of this review? It is ready for review now. - Ajit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43926/#review128436

Re: Review Request 43926: Frameworks support for bulk delete API

2016-04-12 Thread Ajit Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43926/ --- (Updated April 12, 2016, 6:33 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46037: AMBARI-15698 : Metrics is not showing data

2016-04-12 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46037/ --- (Updated April 12, 2016, 11:53 p.m.) Review request for Ambari, Dmytro Sen,

Review Request 46126: Activate HAWQ standby wizard fails to delete previous hawq standby master

2016-04-12 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46126/ --- Review request for Ambari, Alexander Denissov, Alejandro Fernandez, jun aoki,

Re: Review Request 46055: AMBARI-15815: Direct Ambari Upgrade from 2.0.1 to 2.4.x failed with error

2016-04-12 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46055/ --- (Updated April 12, 2016, 8:38 p.m.) Review request for Ambari, Dmytro

Review Request 46136: Unit Test Coverage For Alert Caching

2016-04-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46136/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-13569

Review Request 46128: AMBARI-15851 FE work to integrate "Service version display should be based on Version Definition"

2016-04-12 Thread Zhe (Joe) Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46128/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128595 ---

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/#review128584 --- Ship it! Ship It! - Matt On April 12, 2016, 12:12 p.m.,

Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, Jayush Luniya,

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128600 --- Ship it! Ship It! - Alejandro Fernandez On April 12, 2016,

Re: Review Request 46127: [PREVIEW] Add support for Rolling and Express Upgrade for Hive Server Interactive and LLAP

2016-04-12 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46127/#review128610 ---

Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/ --- Review request for Ambari, Alejandro Fernandez, jun aoki, Jayush Luniya, and

Review Request 46076: Enable HDFS alerts based on AMS metrics by default.

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46076/ --- Review request for Ambari, Andrew Onischuk, Aravindan Vijayan, and Sid Wagle.

Re: Review Request 46079: Build and Test SLES 12 Ambari with SLES 12 HDP builds.

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46079/#review128364 --- Ship it! Ship It! - Dmytro Sen On Апрель 12, 2016, 9:39

Re: Review Request 46079: Build and Test SLES 12 Ambari with SLES 12 HDP builds.

2016-04-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46079/#review128358 --- Ship it! Ship It! - Andrew Onischuk On April 12, 2016, 9:39

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128352 ---

Review Request 46082: Tittle of permissions window spilling out of the line.

2016-04-12 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46082/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.

Re: Review Request 46072: HAWQ HDFS directory should be owned by postgres user if secured

2016-04-12 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46072/#review128363 ---

Re: Review Request 46076: Enable HDFS alerts based on AMS metrics by default.

2016-04-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46076/#review128347 --- Ship it! Ship It! - Andrew Onischuk On April 12, 2016, 8:17

Review Request 46079: Build and Test SLES 12 Ambari with SLES 12 HDP builds.

2016-04-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46079/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 46082: Tittle of permissions window spilling out of the line.

2016-04-12 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46082/#review128360 --- Ship it! Ship It! - DIPAYAN BHOWMICK On April 12, 2016,

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- (Updated ápr. 12, 2016, 12:54 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/#review128373 ---

Re: Review Request 46052: Provide backward compatibility for kdc_host in krb5-conf for krb5.conf templates

2016-04-12 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46052/ --- (Updated April 12, 2016, 8:24 a.m.) Review request for Ambari, Jonathan

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Robert Nettleton
> On April 12, 2016, 9:24 a.m., Sebastian Toader wrote: > > Hi Sebastian, Thanks for the review comments. Please see my replies below. Thanks, Bob > On April 12, 2016, 9:24 a.m., Sebastian Toader wrote: > >

Re: Review Request 46052: Provide backward compatibility for kdc_host in krb5-conf for krb5.conf templates

2016-04-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46052/#review128379 --- Ship it! - Jonathan Hurley On April 12, 2016, 8:24 a.m.,

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- (Updated ápr. 12, 2016, 12:09 du) Review request for Ambari, Laszlo Puskas,

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Andrii Voloshyn
> On April 11, 2016, 8:10 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/fcntl_based_process_lock.py, > > line 29 > > > > > > Can we make this more robust

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128389 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016,

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128398 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016,

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/#review128399 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016,

Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/#review128403 --- Ship it! Ship It! - Myroslav Papirkovskyy On Квітень 12,

Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/#review128406 --- Ship it! Ship It! - Dmytro Sen On Апрель 12, 2016, 2:21

Re: Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/ --- (Updated April 12, 2016, 2:05 p.m.) Review request for Ambari and Vitalyi

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/ --- (Updated ápr. 12, 2016, 1:51 du) Review request for Ambari, Laszlo Puskas,

Review Request 46095: On debian7 UI shows 'os not supported' in processor info

2016-04-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46095/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-15836

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/ --- (Updated April 12, 2016, 2:30 p.m.) Review request for Ambari, Sumit Mohanty

Re: Review Request 46021: Audit logging cleanup and tests

2016-04-12 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46021/#review128416 --- Ship it! Ship It! - Sandor Magyari On April 12, 2016, 1:51

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45978/ --- (Updated April 12, 2016, 3:02 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46055: AMBARI-15815: Direct Ambari Upgrade from 2.0.1 to 2.4.x failed with error

2016-04-12 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46055/#review128412 --- Ship it! Ship It! - Jonathan Hurley On April 11, 2016, 7:02

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Oliver Szabo
> On April 11, 2016, 9:07 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 174 > > > > > > Knox log dir may be configurable.

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128408 --- Ship it! Ship It! - Vitalyi Brodetskyi On Квітень 12, 2016,

Re: Review Request 45872: Component install post processing can not be run in parallel

2016-04-12 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45872/#review128417 --- Ship it! Ship It! - Sebastian Toader On April 12, 2016,

Re: Review Request 45978: AMBARI-15806: Stack definition for Logsearch

2016-04-12 Thread Oliver Szabo
> On April 12, 2016, 12:20 p.m., Sebastian Toader wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py, > > line 37 > > > > > > According to the Role command order

Re: Review Request 46099: testUpdateRepoUrlController unit test fails

2016-04-12 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46099/ --- (Updated Апрель 12, 2016, 3:41 п.п.) Review request for Ambari, Andrew

Review Request 46100: Support option to not create a version definition resource but return the structured JSON only

2016-04-12 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46100/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush