Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/ --- (Updated Aug. 19, 2016, 7:54 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

2016-08-19 Thread Nate Cole
> On Aug. 19, 2016, 1:10 p.m., Jonathan Hurley wrote: > > The code in UpgradeHelper is still a bit fragile (even though now you're > > preventing the if-statement from failed. I say we either log the fact that > > we're not scheduling restarts or throw an exception: > > > > //

Re: Review Request 51242: Restify logsearch endpoints

2016-08-19 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/#review146193 --- Fix it, then Ship it! Overall, the change looks like a good

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146202 --- Ship it! Ship It! - Jayush Luniya On Aug. 19, 2016, 4:54

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Dmitro Lisnichenko
> On Aug. 19, 2016, 6:16 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a common

Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

2016-08-19 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

2016-08-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51207/#review146203 --- The path does everythong expected for the 0.0.0.0:6188 revert and

Review Request 51242: Restify logsearch endpoints

2016-08-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert Nettleton,

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

2016-08-19 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/ --- (Updated Сер. 19, 2016, 8:27 після полудня) Review request for Ambari,

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-19 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- (Updated Aug. 19, 2016, 9:55 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

2016-08-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/#review146231 ---

Re: Review Request 51242: Restify logsearch endpoints

2016-08-19 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/ --- (Updated Aug. 19, 2016, 7:57 p.m.) Review request for Ambari, Dharmesh

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Nate Cole
> On Aug. 19, 2016, 11:16 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

2016-08-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146217 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 19, 2016,

Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-19 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Robert Levas,

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

2016-08-19 Thread Jonathan Hurley
> On Aug. 19, 2016, 11:16 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

2016-08-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146218 --- Pushed to trunk, commit c17d98013cf3ae9649f85345c3dc16fae5d8e994

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-19 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- (Updated Aug. 19, 2016, 9:49 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-19 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review145539 ---