Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146171 --- Ship it! Ship It! - Andrew Onischuk On Aug. 18, 2016, 7:42 p

Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- Review request for Ambari, Jayush Luniya, Nate Cole, and Sebastian Toader. Bugs

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146178 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 18, 2016, 10:

Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/ --- Review request for Ambari, Jonathan Hurley, Jayush Luniya, and Nate Cole. Bugs:

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146182 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Review Request 51242: Restify logsearch endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/ --- Review request for Ambari, Dharmesh Makwana, Miklos Gergely, Robert Nettleton, a

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146186 --- Fix it, then Ship it! I think it would be nice to make this a r

Review Request 51243: HiveServer2 dies since ZK unavailable, Ambari 2.0.2 with Ranger + Kerberos is upgraded to Ambari 2.4.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51243/ --- Review request for Ambari, Dmitro Lisnichenko, Sumit Mohanty, and Vitalyi Brodet

Re: Review Request 51243: HiveServer2 dies since ZK unavailable, Ambari 2.0.2 with Ranger + Kerberos is upgraded to Ambari 2.4.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51243/#review146190 --- Ship it! Ship It! - Sumit Mohanty On Aug. 19, 2016, 3:54 p.m

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review146191 --- Ship it! Looks ok. Will need minor refactoring for next version

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/ --- (Updated Aug. 19, 2016, 7:54 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs: AMBAR

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

> On Aug. 19, 2016, 6:16 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a common

Re: Review Request 51242: Restify logsearch endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/#review146193 --- Fix it, then Ship it! Overall, the change looks like a good add

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/#review146196 --- Ship it! The code in UpgradeHelper is still a bit fragile (even

Re: Review Request 51242: Restify logsearch endpoints

> On aug. 19, 2016, 5:03 du, Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java, > > line 30 > > > > > > Another thing to consider

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

> On Aug. 19, 2016, 1:10 p.m., Jonathan Hurley wrote: > > The code in UpgradeHelper is still a bit fragile (even though now you're > > preventing the if-statement from failed. I say we either log the fact that > > we're not scheduling restarts or throw an exception: > > > > // Specia

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/ --- (Updated Aug. 19, 2016, 1:58 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/#review146199 --- Ship it! Ship It! - Jonathan Hurley On Aug. 19, 2016, 1:58 p

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

> On Aug. 19, 2016, 3:41 p.m., Jonathan Hurley wrote: > > I think it would be nice to make this a re-usable class in the future for > > updating Kerberos descriptors. But since we don't have the immediate need > > nor the time, doing a one-off is fine. +1 on make it reusable in the future. -

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146202 --- Ship it! Ship It! - Jayush Luniya On Aug. 19, 2016, 4:54 p.m

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51207/#review146200 --- ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/

Re: Review Request 51207: Wrong hostname in timeline.metrics.service.webapp.address breaks AMS HA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51207/#review146203 --- The path does everythong expected for the 0.0.0.0:6188 revert and

Re: Review Request 51242: Restify logsearch endpoints

> On Aug. 19, 2016, 5:03 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/ServiceLogsREST.java, > > line 29 > > > > > > Maybe I've missed somet

Re: Review Request 51242: Restify logsearch endpoints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51242/ --- (Updated Aug. 19, 2016, 7:57 p.m.) Review request for Ambari, Dharmesh Makwana,

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

> On Aug. 19, 2016, 11:16 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a common

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

> On Aug. 19, 2016, 11:16 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/StormUpgradeKerberosDescriptorConfig.java, > > line 81 > > > > > > Probably use a common

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/ --- (Updated Сер. 19, 2016, 8:27 після полудня) Review request for Ambari, Alejandr

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146217 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 19, 2016, 8:

Re: Review Request 51143: Alert on Atlas after adding it to a secure cluster as HBase table initialization fails

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51143/#review146218 --- Pushed to trunk, commit c17d98013cf3ae9649f85345c3dc16fae5d8e994 b

Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Robert Levas, Sumi

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- (Updated Aug. 19, 2016, 9:49 p.m.) Review request for Ambari, Di Li, Jonathan H

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- (Updated Aug. 19, 2016, 9:55 p.m.) Review request for Ambari, Di Li, Jonathan H

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/#review146221 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 19, 2016, 9:

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/#review146225 --- ambari-server/src/main/java/org/apache/ambari/server/upgrade/Upgr

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On Aug. 19, 2016, 10:46 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, > > line 940 > > > > > > nit: should be a space after comma Please refer to the va

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

> On Aug. 19, 2016, 10:46 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java, > > line 1938 > > > > > > UpgradeCatalog240 is not the best option for t

Re: Review Request 51241: PREVIEW - RU: Storm components were stopped during RU and can not be started

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/#review146230 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 19, 2016, 4:

Re: Review Request 51245: Both NameNodes reporting version mismatches before Finalizing RU

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51245/#review146231 --- ambari-server/src/main/java/org/apache/ambari/server/stack/Master

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review145539 --- ambari-server/src/main/java/org/apache/ambari/server/metrics/syst

Review Request 51255: File View throws IllegalArguementException post Ambari 2.4.0.0 upgrade

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51255/ --- Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshth