Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

2017-12-13 Thread Pravin Dsilva
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64571/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22404

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193647 ---

Re: Review Request 64204: zkfc show no alerts when zkfc is down

2017-12-13 Thread zhangxiaolu zhangxiaolu
> On 十二月 4, 2017, 4:24 p.m., Nate Cole wrote: > > ambari-web/app/mappers/alert_definition_summary_mapper.js > > Lines 94-106 (patched) > > > > > > Strange that this isn't getting covered in the above block. I'm not

Re: Review Request 63786: zookeeper service issue

2017-12-13 Thread zhangxiaolu zhangxiaolu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63786/ --- (Updated 十二月 13, 2017, 11:36 a.m.) Review request for Ambari, Andrii

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193683 --- Ship it! Ship It! - Krisztian Kasa On Dec. 13, 2017, 3:24

Re: Review Request 63955: Validate blueprint does not allow lzo enable without setup with license agreement.

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63955/#review193685 --- Has this been pushed? If so, please close the review. - Nate

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/ --- (Updated Dec. 13, 2017, 3:24 p.m.) Review request for Ambari, Krisztian Kasa

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Oliver Szabo
> On Dec. 13, 2017, 9:22 a.m., Krisztian Kasa wrote: > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/common/ConfigItem.java > > Line 62 (original), 64 (patched) > > > > > >

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193680 ---

Re: Review Request 64571: AMBARI-22404: Set java.home. in ambari-server setup script for server OS family

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64571/#review193682 --- ambari-server/src/main/python/ambari_server/serverSetup.py Lines

Re: Review Request 63957: Stack advisor should disallow lzo enable without accepting license agreement.

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63957/#review193684 --- Has this been pushed? If so, please close the review. - Nate

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Vishal Suvagia via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64537/ --- (Updated Dec. 13, 2017, 3:42 p.m.) Review request for Ambari, Gautam Borad,

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Vishal Suvagia via Review Board
> On Dec. 12, 2017, 4:36 p.m., Sid Wagle wrote: > > Instead of putting empty files on the classpath isn't it easier to check > > for file existence on plugin side and defaul to "simple" auth? > > Sid Wagle wrote: > Correction not empty I meant dummy file. Thank-you Siddharth, that is the

Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same

2017-12-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64568/#review193698 --- Ship it! Ship It! - Robert Levas On Dec. 13, 2017, 1:54

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/ --- (Updated Dec. 13, 2017, 10:46 a.m.) Review request for Ambari, Dmytro

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Robert Levas
> On Dec. 12, 2017, 11:03 a.m., Nate Cole wrote: > > ambari-web/app/controllers/main/admin/kerberos/step1_controller.js > > Lines 45-47 (patched) > > > > > > Is this, or can this be made to show conditionally if

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64542/#review193700 --- Ship it! Ship It! - Eugene Chekanskiy On Dec. 12, 2017,

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193702 --- Ship it! Ship It! - Nate Cole On Dec. 13, 2017, 10:46 a.m.,

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193705 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 13, 2017,

Re: Review Request 64542: Kerberos support for OneFS

2017-12-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64542/#review193704 --- Ship it! Ship It! - Robert Levas On Dec. 12, 2017, 10:38

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Jonathan Hurley
> On Dec. 13, 2017, 10:04 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > > Lines 29-31 (original), 41-47 (patched) > > > > > > Only in WINSRV?

Review Request 64579: Node Managers fail to start after Spark2 is patched due to CNF YarnShuffleService

2017-12-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64579/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.

Re: Review Request 64579: Node Managers fail to start after Spark2 is patched due to CNF YarnShuffleService

2017-12-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64579/#review193703 --- Ship it! Ship It! - Nate Cole On Dec. 13, 2017, 12:12 p.m.,

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

2017-12-13 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64118/ --- (Updated Dec. 13, 2017, 6:14 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

2017-12-13 Thread Eugene Chekanskiy
> On Dec. 12, 2017, 6:54 p.m., Robert Levas wrote: > > This is looking really good. Upgrade logic to the appropriate > > UpgradeCatalog class. Upgrade will be seperate patch. I want to finish server and agent side changes to implement upgrade after all tables and data are stable. > On Dec.

Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same

2017-12-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64568/#review193711 --- Ship it! Ship It! - Robert Nettleton On Dec. 13, 2017, 6:54

Re: Review Request 64554: HBase Cannot Find LZO Classes After Being Patched

2017-12-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64554/#review193720 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 13, 2017, 3:46

Re: Review Request 64568: AMBARI-22638. yarn.timeline-service property enabled overriding preset secure blueprint config for the same

2017-12-13 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64568/#review193710 --- Ship it! Ship It! - Balázs Bence Sári On Dec. 13, 2017,

Re: Review Request 64579: Node Managers fail to start after Spark2 is patched due to CNF YarnShuffleService

2017-12-13 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64579/#review193721 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 13, 2017, 5:12

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64537/#review193734 --- Ship it! Ship It! - Sid Wagle On Dec. 13, 2017, 3:42 p.m.,

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64553/#review193736 --- Ship it!

Re: Review Request 64537: AMBARI-22635 : Ambari should create a dummy core-site.xml for Ranger plugins when namenode is not installed.

2017-12-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64537/#review193731 --- Ship it! Ship It! - Jonathan Hurley On Dec. 13, 2017, 10:42

Re: Review Request 64553: Log Feeder refactor: integrate with spring boot

2017-12-13 Thread Oliver Szabo
> On Dec. 13, 2017, 9:18 p.m., Sid Wagle wrote: > > ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java > > Lines 40 (patched) > > > > > >

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64544/ --- (Updated Dec. 13, 2017, 5:01 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 64544: Migrate user data for upgrade to improved user account management

2017-12-13 Thread Robert Levas
> On Dec. 12, 2017, 11:44 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java > > Lines 175-192 (patched) > > > > > > Interesting .. is this