Re: Review Request 46271: Migrate instance specific data from one version to another.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46271/#review130300 --- Ship it! Ship It! - Ashwin Rajeev On April 20, 2016, 7:47

Re: Review Request 46689: Not able to edit Pig script tab

/resources/files/FileService.java (line 207) <https://reviews.apache.org/r/46689/#comment194416> Possible NPE if filepath is null, I am not sure if this is ever possible. just double check this - Ashwin Rajeev On April 26, 2016, 9:55 a.m., Gaurav Nagar

Re: Review Request 46689: Not able to edit Pig script tab

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46689/#review130591 --- Ship it! Ship It! - Ashwin Rajeev On April 26, 2016, 9:55

Re: Review Request 46738: Converting cluster to Kerberos the views should automatically adjust and work prior to the kerberization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46738/#review130774 --- Ship it! Ship It! - Ashwin Rajeev On April 27, 2016, 12:49

Re: Review Request 47023: Views: Simplify View Configuration for Remote Ambari Managed Cluster. Ambari Server Side changes

n/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java (line 254) <https://reviews.apache.org/r/47023/#comment195946> If you want to , use Strings.isNullOrEmpty() - Guava - Ashwin Rajeev On May 5, 2016, 4:16 p.m., Gaurav

Re: Review Request 47124: Hive View : Upload Table- Error on uploading csv with 1 row

/resources/uploads/UploadService.java (line 355) <https://reviews.apache.org/r/47124/#comment196584> Can inputFileType ever be null ?, if not then ignore this comment - Ashwin Rajeev On May 10, 2016, 9:47 a.m., Nitiraj Rathore

Re: Review Request 47294: Upgrading ambari server fails when trying to create cluster_type column

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47294/#review132847 --- Ship it! Ship It! - Ashwin Rajeev On May 12, 2016, 7:55 a.m

Re: Review Request 47175: Hive View : Upload table : show UI validation errors while creating table.

- > > (Updated May 12, 2016, 12:51 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, and Ashwin Rajeev. > > > Bugs: AMBARI-16422 > https://issues.apache.org/jira/browse/AMBARI-16422 &

Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46962/#review133929 --- Ship it! Ship It! - Ashwin Rajeev On May 17, 2016, 10:10

Re: Review Request 47604: View URLs: UX edits #4

/controllers/ambariViews/ViewsEditCtrl.js (line 446) <https://reviews.apache.org/r/47604/#comment198658> pls remove console.log - Ashwin Rajeev On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote: > > --- > This is a

Re: Review Request 47604: View URLs: UX edits #4

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47604/#review133993 --- Ship it! Fix it then ship it - Ashwin Rajeev On May 19

Re: Review Request 47460: Explain script on pig views encountered an IOExecption

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47460/#review133998 --- Ship it! Ship It! - Ashwin Rajeev On May 17, 2016, 3 p.m

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47527/#review134096 --- Ship it! Fix it then ship it - Ashwin Rajeev On May 19

Re: Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.

r.java (line 140) <https://reviews.apache.org/r/47527/#comment198743> Same here - Ashwin Rajeev On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47524/#review134097 --- Ship it! Ship It! - Ashwin Rajeev On May 19, 2016, 10:22

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done

/src/main/resources/ui/hive-web/app/components/file-upload.js (line 30) <https://reviews.apache.org/r/47525/#comment198744> Remove logging - Ashwin Rajeev On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote: > > ---

Re: Review Request 47526: Hive View : History tab in hive view does not show recent jobs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47526/#review134100 --- Ship it! Ship It! - Ashwin Rajeev On May 19, 2016, 10:22

Re: Review Request 47525: Hive View : Upload table still shows file name after the upload is done

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47525/#review134129 --- Ship it! Ship It! - Ashwin Rajeev On May 20, 2016, 10:16

Re: Review Request 47644: All created views disappear after upgrade to 2.4.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47644/#review134146 --- Ship it! Ship It! - Ashwin Rajeev On May 20, 2016, 10:15

Re: Review Request 48032: Not able to save custom config in view config

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48032/#review135506 --- Ship it! Ship It! - Ashwin Rajeev On May 30, 2016, 8:55 a.m

Re: Review Request 48681: Ambari views logs should be more verbose and should include info/error/debug logs at appropriate places

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48681/#review138162 --- Ship it! Ship It! - Ashwin Rajeev On June 14, 2016, 10:20

Re: Review Request 49379: Hive2 view : port changes of following 10 bugs in hive2 view

- > > (Updated June 29, 2016, 2:46 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav > Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. > > > Bugs: AMBARI-17480 > https://issues.apache.org/jira/browse/AMBARI-17480 > > > Repo

Re: Review Request 49433: Pig - Pig Helper - Relational Operator - GROUP and COGROUP function when selected, param section display incorrect number of param

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49433/#review140135 --- Ship it! Ship It! - Ashwin Rajeev On June 30, 2016, 11 a.m

Re: Review Request 49450: Port changes of AMBARI-17421 to hive-jdbc view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49450/#review140166 --- Ship it! Ship It! - Ashwin Rajeev On June 30, 2016, 1:57

Re: Review Request 49495: Upload Table - picks different datatype for same file, for different hive view version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49495/#review140324 --- Ship it! Ship It! - Ashwin Rajeev On July 1, 2016, 7:31 a.m

Re: Review Request 49991: Rerunning View data migration commands throwing exception

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49991/#review142228 --- Ship it! Ship It! - Ashwin Rajeev On July 13, 2016, 4:37

Re: Review Request 50031: Error for Pig view after upgrade to 2.4.0.0 [PersistenceException: Can't initialize data store for view PIG]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50031/#review142237 --- Ship it! Ship It! - Ashwin Rajeev On July 14, 2016, 1:09

Re: Review Request 50074: Tez views disappear and can not be created after upgrade to 2.4.0.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50074/#review142367 --- Ship it! Ship It! - Ashwin Rajeev On July 15, 2016, 11:43

Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49750/#review142540 --- Ship it! Ship It! - Ashwin Rajeev On July 7, 2016, 11:32

Re: Review Request 50189: Getting error while executing query for adding udf jar

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50189/#review142735 --- Ship it! Ship It! - Ashwin Rajeev On July 19, 2016, 12:13

Re: Review Request 48850: Views in Ambari UI don't render when proxied by Knox

fine - Ashwin Rajeev On June 17, 2016, 1:44 p.m., Aleksandr Kovalenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 50305: Views in Ambari UI don't render when proxied by Knox - contrib views

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50305/#review143126 --- Ship it! Ship It! - Ashwin Rajeev On July 21, 2016, 6:38

Re: Review Request 50328: Local and custom views are not working when swebhdfs and Namenode HA is enabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50328/#review143205 --- Ship it! Ship It! - Ashwin Rajeev On July 22, 2016, 6:55

Re: Review Request 50554: Ambari upgrade reports error upgrading view tables - possibly not an error but confusing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50554/#review144061 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:37

Re: Review Request 50790: Hive View History not showing old queries after upgrade.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50790/#review144751 --- Ship it! Ship It! - Ashwin Rajeev On Aug. 4, 2016, 12:19

Re: Review Request 50792: "ItemNotFound" error on uploading table hive View

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50792/#review144753 --- Ship it! Ship It! - Ashwin Rajeev On Aug. 4, 2016, 12:54

Re: Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50691/#review144878 --- Ship it! Reviewed earleier as a github PR - Ashwin Rajeev

Re: Review Request 52822: Ambari Hive View 'Upload Table' does not support UTF8 files with BOM

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52822/#review152474 --- Ship it! Ship It! - Ashwin Rajeev On Oct. 13, 2016, 8:56

Re: Review Request 50561: Hive View Upload table does not support line feed and carriage return in field delimiter

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50561/#review152475 --- Ship it! Ship It! - Ashwin Rajeev On July 28, 2016, 11:22

Re: Review Request 52823: For Upload Table on hive view, upload fails when file extension is .json

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52823/#review154505 --- Ship it! Ship It! - Ashwin Rajeev On Oct. 13, 2016, 9:06

Re: Review Request 53780: create separate RPM / DEB package for views during build process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53780/#review156192 --- Ship it! Ship It! - Ashwin Rajeev On Nov. 15, 2016, 11:54

Re: Review Request 55050: Remove hive view 1.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55050/#review160180 --- Ship it! Ship It! - Ashwin Rajeev On Dec. 27, 2016, 5:58

Re: Review Request 54305: Hive view history tab does not list queries, if there are large number of queries

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54305/#review160181 --- Ship it! Ship It! - Ashwin Rajeev On Dec. 27, 2016, 6:26

Re: Review Request 55090: Hive View 2.0 - Minimal view for Hive which includes new UI changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55090/#review160375 --- Ship it! Ship It! - Ashwin Rajeev On Jan. 3, 2017, 9:25 a.m

Re: Review Request 55209: ATS service check failed on navigating to Hive View

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55209/#review160690 --- Ship it! Ship It! - Ashwin Rajeev On Jan. 5, 2017, 1:30 p.m

Re: Review Request 56973: Hive view 2.0 : Hanging query - no cancel available

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56973/#review166491 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 23, 2017, 7:13

Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57120/#review167007 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 28, 2017, 4:55

Re: Review Request 57141: Hive View 2.0: Code hints for query editor are not working

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57141/#review167094 --- Ship it! Ship It! - Ashwin Rajeev On Feb. 28, 2017, 12:23

Re: Review Request 57453: Fix up tez view version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/#review168427 --- Ship it! Ship It! - Ashwin Rajeev On March 9, 2017, 10 a.m

Re: Review Request 57453: Fix up tez view version

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57453/#review168915 --- Ship it! Ship It! - Ashwin Rajeev On March 14, 2017, 1:59

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58997/#review174148 --- Ship it! Ship It! - Ashwin Rajeev On May 5, 2017, 9:12 a.m

Re: Review Request 58997: Users are not able to login to ambari UI after Ambari upgrade from 2.4.x to 2.5.0

/UpgradeCatalog250.java Lines 692 (patched) <https://reviews.apache.org/r/58997/#comment247267> Does it need to be hardcoded ? - Ashwin Rajeev On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote: > > --- > This is an automati