Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
> On April 1, 2016, 2:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java, > > line 251 > > > > > > Do both of

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126625 --- Ship it! Decrease the timeout during the unit test and ship it

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126619 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/ --- (Updated April 1, 2016, 12:43 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
> On April 1, 2016, 12:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/repository/VersionDefinitionXml.java, > > line 230 > > > > > > Does the schema factory close the

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/#review126595 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 45586: Provide an in-memory representation of available VDF

2016-04-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45586/ --- (Updated April 1, 2016, 10:52 a.m.) Review request for Ambari, Alejandro Fernan