Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-21 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/#review129898
---


Ship it!




- Nate Cole


On April 18, 2016, 12:22 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45924/
> ---
> 
> (Updated April 18, 2016, 12:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15681
> https://issues.apache.org/jira/browse/AMBARI-15681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> 
> Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot 
> be updated from Ambari. This forces the users to directly edit the 
> configuration file.
> 
> **Proposed Solution**
> Exposing log4j configurations for individual compomnents to Ambari as a 
> properties file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45924/diff/
> 
> 
> Testing
> ---
> 
> Verifed Ranger Admin and usersync log files being created based on configs 
> given in log4j.properties block from Ambari UI.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/#review129326
---



Generally for trunk we don't separate tests into different jira.  Any 
particular reason for that?  For feature branches it's ok because those don't 
go through automated testing.

- Nate Cole


On April 18, 2016, 12:22 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45924/
> ---
> 
> (Updated April 18, 2016, 12:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15681
> https://issues.apache.org/jira/browse/AMBARI-15681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> 
> Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot 
> be updated from Ambari. This forces the users to directly edit the 
> configuration file.
> 
> **Proposed Solution**
> Exposing log4j configurations for individual compomnents to Ambari as a 
> properties file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45924/diff/
> 
> 
> Testing
> ---
> 
> Verifed Ranger Admin and usersync log files being created based on configs 
> given in log4j.properties block from Ambari UI.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-17 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/
---

(Updated April 18, 2016, 4:22 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.


Changes
---

Handled suggested changes, Test cases will be covered in a separate  JIRA.


Bugs: AMBARI-15681
https://issues.apache.org/jira/browse/AMBARI-15681


Repository: ambari


Description
---

**Problem Statement**

Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot be 
updated from Ambari. This forces the users to directly edit the configuration 
file.

**Proposed Solution**
Exposing log4j configurations for individual compomnents to Ambari as a 
properties file.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 86dbc48 
  
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
 7201c36 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 c0ab3e8 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 9544ee8 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 03b7e01 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45924/diff/


Testing
---

Verifed Ranger Admin and usersync log files being created based on configs 
given in log4j.properties block from Ambari UI.


Thanks,

Gautam Borad

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/#review127857
---




ambari-common/src/main/python/resource_management/libraries/functions/constants.py
 (line 79)


Nitpicking: Keep constant name and value the same (except for the case. 
RANGER_LOG4J_SUPPORT = "ranger_log4j_support"


- Jayush Luniya


On April 8, 2016, 11:20 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45924/
> ---
> 
> (Updated April 8, 2016, 11:20 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15681
> https://issues.apache.org/jira/browse/AMBARI-15681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> 
> Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot 
> be updated from Ambari. This forces the users to directly edit the 
> configuration file.
> 
> **Proposed Solution**
> Exposing log4j configurations for individual compomnents to Ambari as a 
> properties file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45924/diff/
> 
> 
> Testing
> ---
> 
> Verifed Ranger Admin and usersync log files being created based on configs 
> given in log4j.properties block from Ambari UI.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 45924: AMBARI-15681 : Ranger Admin/Usersync: Make log4j configurable from Ambari

2016-04-08 Thread Jayush Luniya 


> On April 8, 2016, 1:32 p.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py,
> >  line 218
> > 
> >
> > Use the AMBARI- JIRA number.

+1


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45924/#review127779
---


On April 8, 2016, 11:20 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45924/
> ---
> 
> (Updated April 8, 2016, 11:20 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, 
> Nate Cole, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-15681
> https://issues.apache.org/jira/browse/AMBARI-15681
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> **Problem Statement**
> 
> Currently log4j configuration for Ranger Admin / UserSync and TagSync cannot 
> be updated from Ambari. This forces the users to directly edit the 
> configuration file.
> 
> **Proposed Solution**
> Exposing log4j configurations for individual compomnents to Ambari as a 
> properties file.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py
>  86dbc48 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py
>  7201c36 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  c0ab3e8 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  9544ee8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  03b7e01 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/admin-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/tagsync-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER/configuration/usersync-log4j.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45924/diff/
> 
> 
> Testing
> ---
> 
> Verifed Ranger Admin and usersync log files being created based on configs 
> given in log4j.properties block from Ambari UI.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>