Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46046/#review128236
---


Ship it!




Ship It!

- Alejandro Fernandez


On April 11, 2016, 7:27 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46046/
> ---
> 
> (Updated April 11, 2016, 7:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15810
> https://issues.apache.org/jira/browse/AMBARI-15810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The API is filtering Request objects in an inconsistent manner.  When 
> accessing /clusters/c1/requests, the db query includes non-cluster calls, 
> which get filtered out.  The UI then sees the count returned less than the 
> count asked for, and does not allow any more queries.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  c1e9053 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> dcbf2a6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  bbb55f3 
> 
> Diff: https://reviews.apache.org/r/46046/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4132, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:41.820s
> [INFO] Finished at: Mon Apr 11 14:17:50 EDT 2016
> [INFO] Final Memory: 34M/766M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Nate Cole 


> On April 11, 2016, 3:33 p.m., Jonathan Hurley wrote:
> > So with this change, we're basically removing the ability to get back all 
> > cluster and host requests in the same query, right? I think that's OK.

Correct.  We could make the /requests (no cluster) one include the 
cluster-based ones, but it's not working that way today anyway so it's not a 
real change in functionality.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46046/#review128218
---


On April 11, 2016, 3:27 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46046/
> ---
> 
> (Updated April 11, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15810
> https://issues.apache.org/jira/browse/AMBARI-15810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The API is filtering Request objects in an inconsistent manner.  When 
> accessing /clusters/c1/requests, the db query includes non-cluster calls, 
> which get filtered out.  The UI then sees the count returned less than the 
> count asked for, and does not allow any more queries.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  c1e9053 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> dcbf2a6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  bbb55f3 
> 
> Diff: https://reviews.apache.org/r/46046/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4132, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:41.820s
> [INFO] Finished at: Mon Apr 11 14:17:50 EDT 2016
> [INFO] Final Memory: 34M/766M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 46046: Not all operations shown on 'Background Operations' window

2016-04-11 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46046/#review128218
---


Ship it!




So with this change, we're basically removing the ability to get back all 
cluster and host requests in the same query, right? I think that's OK.


ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
 (line 130)


Nice!


- Jonathan Hurley


On April 11, 2016, 3:27 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46046/
> ---
> 
> (Updated April 11, 2016, 3:27 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15810
> https://issues.apache.org/jira/browse/AMBARI-15810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The API is filtering Request objects in an inconsistent manner.  When 
> accessing /clusters/c1/requests, the db query includes non-cluster calls, 
> which get filtered out.  The UI then sees the count returned less than the 
> count asked for, and does not allow any more queries.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
>  c1e9053 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java 
> dcbf2a6 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
>  bbb55f3 
> 
> Diff: https://reviews.apache.org/r/46046/diff/
> 
> 
> Testing
> ---
> 
> Manual.  Automated:
> 
> Tests run: 4132, Failures: 0, Errors: 0, Skipped: 32
> 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 36:41.820s
> [INFO] Finished at: Mon Apr 11 14:17:50 EDT 2016
> [INFO] Final Memory: 34M/766M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Nate Cole
> 
>