Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/#review131959 --- Ship it! Ship It! - Jayush Luniya On May 5, 2016, 7:44

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Nate Cole
> On May 5, 2016, 4:10 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java, > > line 800 > > > > > > Ewww... Log? Will fix.

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Nate Cole
> On May 5, 2016, 4:10 p.m., Jonathan Hurley wrote: > > So the web client can correctly handle a NSRE correctly here? It would be > > nice to have been able to return a 2xx code, like 204. Yes, the UpdateHandler uses exception-catching as logic (ugh) and propagates a NSRE for collection-based

Re: Review Request 47038: Re-installation of components when there are no INSTALL_FAILED components returns 500 error

2016-05-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47038/#review131915 --- Fix it, then Ship it! So the web client can correctly handle a