Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review140029
---




ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 (line 377)


Please use a constant at least and a code comment that it is currently 
hardcoded (including the file and line number on the backend side).

We should make it easier to change any hardcodings we introduce.


- Alejandro Fernandez


On June 28, 2016, 6:08 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 28, 2016, 6:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-29 Thread Mugdha Varadkar 


> On June 28, 2016, 12:53 p.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py,
> >  line 348
> > 
> >
> > Is `keyadmin` a hardcoded username on the server-side of this URL, or 
> > is this configurable?  Should `keyadmin` be a variable instead?

keyadmin is hardcoded username on server-side


> On June 28, 2016, 12:53 p.m., Robert Levas wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py,
> >  line 377
> > 
> >
> > Is `keyadmin` a hardcoded username on the server-side of this URL, or 
> > is this configurable?  Should `keyadmin` be a variable instead?

same as above


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139773
---


On June 28, 2016, 6:08 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 28, 2016, 6:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-28 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139773
---


Ship it!




Ship It!


ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 (line 348)


Is `keyadmin` a hardcoded username on the server-side of this URL, or is 
this configurable?  Should `keyadmin` be a variable instead?



ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 (line 377)


Is `keyadmin` a hardcoded username on the server-side of this URL, or is 
this configurable?  Should `keyadmin` be a variable instead?


- Robert Levas


On June 28, 2016, 2:08 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 28, 2016, 2:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> c633230 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  a4a38c1 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  26e9c8b 
>   ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-27 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/
---

(Updated June 28, 2016, 6:08 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, 
Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Added Ranger KMS test for stack 2.5


Bugs: AMBARI-17333
https://issues.apache.org/jira/browse/AMBARI-17333


Repository: ambari


Description
---

Fix for get/create repo call for Ranger KMS.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
 05beadb 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
c633230 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 a4a38c1 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 26e9c8b 
  ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-default.json 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/49072/diff/


Testing
---

Test Ranger KMS installation on centos6


Thanks,

Mugdha Varadkar

Re: Review Request 49072: AMBARI-17333 ranger kms repo creation is failing after ranger kms is installed

2016-06-22 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49072/#review139062
---



Can we get some unit tests to cover this case?

- Jonathan Hurley


On June 22, 2016, 4:58 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49072/
> ---
> 
> (Updated June 22, 2016, 4:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan 
> Hurley, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17333
> https://issues.apache.org/jira/browse/AMBARI-17333
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix for get/create repo call for Ranger KMS.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py
>  05beadb 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
>  5847984 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
>  452be86 
> 
> Diff: https://reviews.apache.org/r/49072/diff/
> 
> 
> Testing
> ---
> 
> Test Ranger KMS installation on centos6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>