Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-29 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review140027
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 27, 2016, 10:37 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 27, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing disabeling/enabling ambari-server via 'update-rc.d 
> ambari-server disable/enable'
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-29 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review139961
---


Ship it!




Ship It!

- Andrew Onischuk


On June 27, 2016, 10:37 p.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 27, 2016, 10:37 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> Manual testing disabeling/enabling ambari-server via 'update-rc.d 
> ambari-server disable/enable'
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-27 Thread Sebastian Toader 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/
---

(Updated June 28, 2016, 12:37 a.m.)


Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.


Bugs: AMBARI-17419
https://issues.apache.org/jira/browse/AMBARI-17419


Repository: ambari


Description
---

Trying do disable auto-start for ambari-server by executing update-rc.d 
ambari-server disable is failing with update-rc.d: error: ambari-server 
Default-Start contains no runlevels, aborting.

Added LSB to ambari-server and amabri-agent to define the default start and 
stop levels


Diffs
-

  ambari-agent/etc/init.d/ambari-agent b2c3109 
  ambari-server/sbin/ambari-server 72d94ed 

Diff: https://reviews.apache.org/r/49188/diff/


Testing (updated)
---

Manual testing disabeling/enabling ambari-server via 'update-rc.d ambari-server 
disable/enable'


Thanks,

Sebastian Toader

Re: Review Request 49188: Disabling the auto-start for ambari-server and ambari-agent doesn't work on systemd

2016-06-25 Thread Sebastian Toader 


> On June 24, 2016, 8:04 p.m., Alejandro Fernandez wrote:
> > ambari-agent/etc/init.d/ambari-agent, line 22
> > 
> >
> > These are only code comments, what's the fix?

Newer linux distributions use systemd for managing services. systemd supports 
the  '/etc/init.d' scripts as well via 'insserv' but that requires this LSB 
section to be added to the start script of the service.

Without this when someone executes 'update-rc.d ambari-server disable' to 
remove ambari to be restarted in case the host is rebooted the user will get an 
error: 'update-rc.d: error: ambari-server Default-Start contains no runlevels, 
aborting.' 

This is the format how Linux Standard Base has to be specified.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49188/#review139390
---


On June 24, 2016, 9:56 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49188/
> ---
> 
> (Updated June 24, 2016, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Andrew Onischuk.
> 
> 
> Bugs: AMBARI-17419
> https://issues.apache.org/jira/browse/AMBARI-17419
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Trying do disable auto-start for ambari-server by executing update-rc.d 
> ambari-server disable is failing with update-rc.d: error: ambari-server 
> Default-Start contains no runlevels, aborting.
> 
> Added LSB to ambari-server and amabri-agent to define the default start and 
> stop levels
> 
> 
> Diffs
> -
> 
>   ambari-agent/etc/init.d/ambari-agent b2c3109 
>   ambari-server/sbin/ambari-server 72d94ed 
> 
> Diff: https://reviews.apache.org/r/49188/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>