Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-22 Thread Li-Wei Tseng 


> On Aug. 20, 2016, 12:02 a.m., Alejandro Fernandez wrote:
> >

I will add a javadoc for next patch


- Li-Wei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review145539
---


On Aug. 18, 2016, 6:03 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 18, 2016, 6:03 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml 0d91458 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  097f01c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  256f0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-19 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review145539
---




ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 (line 31)


Add javadoc for what this class does.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 47)


Add javadoc


- Alejandro Fernandez


On Aug. 18, 2016, 6:03 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 18, 2016, 6:03 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml 0d91458 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  097f01c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  256f0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-19 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review146191
---


Ship it!




Looks ok. Will need minor refactoring for next version (with 
DatabaseMetricsSource)

- Aravindan Vijayan


On Aug. 18, 2016, 6:03 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 18, 2016, 6:03 p.m.)
> 
> 
> Review request for Ambari and Aravindan Vijayan.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml 0d91458 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  097f01c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  256f0d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-18 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 18, 2016, 6:03 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Changes
---

Switched branch to trunk


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml 0d91458 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 097f01c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 256f0d1 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-17 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review146045
---


Ship it!




Ship It!

- Aravindan Vijayan


On Aug. 17, 2016, 10:17 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 17, 2016, 10:17 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml e999d03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a6d8d6a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  2bd7eff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-17 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 17, 2016, 10:17 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Changes
---

Catch Exception when metrics.properties is absent


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-17 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review146042
---



Can we have this tested on a cluster with no metrics.proerties file?

- Aravindan Vijayan


On Aug. 16, 2016, 11:23 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 16, 2016, 11:23 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml e999d03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a6d8d6a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  2bd7eff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-16 Thread Sid Wagle 


> On Aug. 16, 2016, 11:28 p.m., Sid Wagle wrote:
> > Ship It!

This should be in trunk vs branch-2.4


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review145928
---


On Aug. 16, 2016, 11:23 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 16, 2016, 11:23 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml e999d03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a6d8d6a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  2bd7eff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-16 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review145928
---


Ship it!




Ship It!

- Sid Wagle


On Aug. 16, 2016, 11:23 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 16, 2016, 11:23 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml e999d03 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  a6d8d6a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  2bd7eff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-16 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 16, 2016, 11:23 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-15 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 15, 2016, 10:51 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-15 Thread Li-Wei Tseng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/
---

(Updated Aug. 15, 2016, 10:41 p.m.)


Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
Yusaku Sako.


Changes
---

Fixed review issues, and included a Grafana dashboard graph for Ambari server


Bugs: AMBARI-17591
https://issues.apache.org/jira/browse/AMBARI-17591


Repository: ambari


Description
---

Created metrics service which has a JVM metrics source and a sink. The JVM 
metrics source collect JVM metrics and pass it to the sink which then publish 
the metrics to AMS


Diffs (updated)
-

  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/conf/unix/metrics.properties PRE-CREATION 
  ambari-server/pom.xml c2ee86d 
  ambari-server/pom.xml e999d03 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5d0bb18 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 a6d8d6a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
 2bd7eff 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/JvmMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/SystemMetricsSource.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/files/grafana-dashboards/default/grafana-ambari-server.json
 PRE-CREATION 

Diff: https://reviews.apache.org/r/50995/diff/


Testing
---

Manually tested it.


Thanks,

Li-Wei Tseng

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-11 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50995/#review145538
---




ambari-server/conf/unix/metrics.properties (line 24)


We should call the source JvmMetricsSource instead of System since system 
also means OS level stats.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 (line 38)


Add doc as to what form of URI is expected.
This code xould break since there are not checks on input URI just appends.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
 (line 42)


Shouldn't this look something like Map> ?

Seems as though there is no fan-out here. We collect more often than we 
publish, generally.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
 (line 46)


Same classloader loads class, this seems very odd? You can use your own 
classloader instead.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 41)


Explicit imports only.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 103)


Null check ?



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 104)


formatting.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 105)


Is null check needed?



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 125)


Why tmp_sources: missed naming convention here.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
 (line 148)


This should say: Failing scheduling source instead of publish.



ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/SystemMetricsSource.java
 (line 55)


Why static?


- Sid Wagle


On Aug. 11, 2016, 6:21 p.m., Li-Wei Tseng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50995/
> ---
> 
> (Updated Aug. 11, 2016, 6:21 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, Sid Wagle, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-17591
> https://issues.apache.org/jira/browse/AMBARI-17591
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Created metrics service which has a JVM metrics source and a sink. The JVM 
> metrics source collect JVM metrics and pass it to the sink which then publish 
> the metrics to AMS
> 
> 
> Diffs
> -
> 
>   ambari-server/conf/unix/metrics.properties PRE-CREATION 
>   ambari-server/pom.xml c2ee86d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5d0bb18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  2bd7eff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/AmbariMetricSink.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/MetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AbstractMetricsSource.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/AmbariMetricSinkImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/Configuration.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/MetricsServiceImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metrics/system/impl/SystemMetricsSource.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50995/diff/
> 
> 
> Testing
> ---
> 
> Manually tested it.
> 
> 
> Thanks,
> 
> Li-Wei Tseng
> 
>