Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-24 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146687 --- Reverted patch since underlying problem was fixed by AMBARI-18256

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-23 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/ --- (Updated Aug. 23, 2016, 1:34 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146447 --- Ship it! This logic makes me a bit nauseous; it's definitely no

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146426 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 22, 2016, 6:

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez
> On Aug. 22, 2016, 7:33 p.m., Nate Cole wrote: > > Just confirm with Alejandro why he had both a field and a value. One was a boolean to read from the XML file, and the other is the actual calculation by reading from the parent if the XML file did not explicitly provide a value. - Alejandro

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146414 --- Ship it! Just confirm with Alejandro why he had both a field an

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146395 --- ambari-server/src/main/java/org/apache/ambari/server/state/Compon