Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-19 Thread Sandor Magyari
Hi Wang!

The patch is committed to trunk & branch-2.5, you can close now the related 
review request. Please make sure, next time to attach the result of unit tests 
to the Testing section of review request.

BR
Sandor

From: wang yaoxin 
<nore...@reviews.apache.org<mailto:nore...@reviews.apache.org>> on behalf of 
wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>
Reply-To: wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>
Date: Sunday 18 September 2016 11:21
To: Jonathan Hurley <jhur...@hortonworks.com<mailto:jhur...@hortonworks.com>>, 
Sebastian Toader <stoa...@hortonworks.com<mailto:stoa...@hortonworks.com>>, 
Oliver Szabo <osz...@hortonworks.com<mailto:osz...@hortonworks.com>>, Robert 
Nettleton <rnettle...@hortonworks.com<mailto:rnettle...@hortonworks.com>>
Cc: Sandor Magyari <smagy...@hortonworks.com<mailto:smagy...@hortonworks.com>>, 
Attila Doroszlai 
<adorosz...@hortonworks.com<mailto:adorosz...@hortonworks.com>>, wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>, 
Ambari <reviews@ambari.apache.org<mailto:reviews@ambari.apache.org>>
Subject: Re: Review Request 51843: rolling restart datanode cluster name in 
audit log show null

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/51843/


On 九月 16th, 2016, 4:35 p.m. UTC, Attila Doroszlai wrote:

ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java<https://reviews.apache.org/r/51843/diff/4/?file=1499530#file1499530line72>(Diff
 revision 4)

72

AuditEvent event = AuditEventCreatorTestHelper.getEvent(creator, request, 
result);


After adding the missing import, the test fails at this line causes:

Running org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec <<< 
FAILURE! - in 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
postScheduleTest(org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest)
  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Nothing captured yet
at 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73)


Hi Attila, thank you , I have update the diff ,and now it's OK


- wang


On 九月 18th, 2016, 9:20 a.m. UTC, wang yaoxin wrote:

Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.
By wang yaoxin.

Updated 九月 18, 2016, 9:20 a.m.

Bugs: AMBARI-18374<https://issues.apache.org/jira/browse/AMBARI-18374>
Repository: ambari
Description

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Testing

done!


Diffs

  *   
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 (075e328)
  *   
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (1074f0e)

View Diff<https://reviews.apache.org/r/51843/diff/>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-18 Thread wang yaoxin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 18, 2016, 9:20 a.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Attila Doroszlai

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149209
---




ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (line 67)


Missing import of RequestResourceProvider



ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (line 72)


After adding the missing import, the test fails at this line causes:

```
Running 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec 
<<< FAILURE! - in 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest

postScheduleTest(org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest)
  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Nothing captured yet
at 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73)
```


- Attila Doroszlai


On Sept. 16, 2016, 3:44 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 3:44 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149199
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 16, 2016, 1:44 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 1:44 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 1:44 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Changes
---

the new patch


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Robert Nettleton

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149198
---




ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (line 22)


Hi Wang,

Could you please re-post your patch?  

I just attempted to review, and the patch appears to be corrupted, as 
Sandor mentioned.

Thanks.


- Robert Nettleton


On Sept. 16, 2016, 12:54 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Sandor Magyari

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149197
---


Ship it!




Could you please paste the unitest result to 'Testing Done' section. Aslo the 
latest patch seems to be correupted.

- Sandor Magyari


On Sept. 16, 2016, 12:54 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 12:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 12:54 p.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin


> On 九月 16, 2016, 10:58 a.m., Oliver Szabo wrote:
> > after applying the diff i got:
> > [ERROR] 
> > /Users/oszabo/prj/ambari/ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java:[103,5]
> >  cannot find symbol
> >   symbol:   class Map
> >   location: class 
> > org.apache.ambari.server.audit.request.eventcreator.RequestEventCreator
> >   
> > I think java.util.Map is not imported in the RequestEventCreator

Hi ,Oliver, thank you for your kind-hearted offer, I have attach a new patch 
AMBARI-18374_02.patch


- wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149186
---


On 九月 16, 2016, 10:06 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated 九月 16, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review149186
---



after applying the diff i got:
[ERROR] 
/Users/oszabo/prj/ambari/ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java:[103,5]
 cannot find symbol
  symbol:   class Map
  location: class 
org.apache.ambari.server.audit.request.eventcreator.RequestEventCreator
  
I think java.util.Map is not imported in the RequestEventCreator

- Oliver Szabo


On Sept. 16, 2016, 10:06 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 16, 2016, 10:06 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-16 Thread wang yaoxin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/
---

(Updated 九月 16, 2016, 10:06 a.m.)


Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.


Bugs: AMBARI-18374
https://issues.apache.org/jira/browse/AMBARI-18374


Repository: ambari


Description
---

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 075e328 
  
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 1074f0e 

Diff: https://reviews.apache.org/r/51843/diff/


Testing
---

done!


Thanks,

wang yaoxin



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-14 Thread Oliver Szabo

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review148894
---


Ship it!




Ship It!

- Oliver Szabo


On Sept. 14, 2016, 8:31 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 14, 2016, 8:31 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-14 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review148872
---


Ship it!




Ship It!

- Sebastian Toader


On Sept. 14, 2016, 8:04 a.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 14, 2016, 8:04 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
>   
> ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
>  1074f0e 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>



Re: Review Request 51843: rolling restart datanode cluster name in audit log show null

2016-09-13 Thread Sebastian Toader

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51843/#review148703
---




ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 (line 90)


Please add a unit test for this change.


- Sebastian Toader


On Sept. 13, 2016, 2:25 p.m., wang yaoxin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51843/
> ---
> 
> (Updated Sept. 13, 2016, 2:25 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Robert Nettleton, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-18374
> https://issues.apache.org/jira/browse/AMBARI-18374
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
> null
> 
> 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
> Operation(Request from server), RequestType(POST), 
> url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
> Accepted), Command(RESTART), Cluster name(null)
> 
> 2016-09-13T17:29:22.042+0800, User(admin), 
> Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
> RequestId(15)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
>  075e328 
> 
> Diff: https://reviews.apache.org/r/51843/diff/
> 
> 
> Testing
> ---
> 
> done!
> 
> 
> Thanks,
> 
> wang yaoxin
> 
>