Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-11-14 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/#review155830
---


Ship it!




Ship It!

- Robert Levas


On Nov. 14, 2016, 11:56 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52930/
> ---
> 
> (Updated Nov. 14, 2016, 11:56 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14384
> https://issues.apache.org/jira/browse/AMBARI-14384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Kerberos enabled cluster
> * SPNEGO enabled on hadoop APIs
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> The same problem appears to be happening on the sinks:
> * 
> ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
> ** No SPNEGO support
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml fb01c81 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  5a716df 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
>  2b9964b 
> 
> Diff: https://reviews.apache.org/r/52930/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-11-14 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/
---

(Updated Ноя. 14, 2016, 4:56 п.п.)


Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.


Bugs: AMBARI-14384
https://issues.apache.org/jira/browse/AMBARI-14384


Repository: ambari


Description
---

* Kerberos enabled cluster
* SPNEGO enabled on hadoop APIs

/var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
http://metrics-collector:6188/ws/v1/timeline/metrics
2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
server. HTTP Error 401: Authentication required
2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...

The same problem appears to be happening on the sinks:
* 
ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
** No SPNEGO support


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml fb01c81 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 5a716df 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-metrics2.properties.xml
 2b9964b 

Diff: https://reviews.apache.org/r/52930/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-24 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/
---

(Updated Окт. 24, 2016, 2:31 п.п.)


Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.


Bugs: AMBARI-14384
https://issues.apache.org/jira/browse/AMBARI-14384


Repository: ambari


Description
---

* Kerberos enabled cluster
* SPNEGO enabled on hadoop APIs

/var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
http://metrics-collector:6188/ws/v1/timeline/metrics
2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
server. HTTP Error 401: Authentication required
2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...

The same problem appears to be happening on the sinks:
* 
ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
** No SPNEGO support


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 efa5cba 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 3d00270 

Diff: https://reviews.apache.org/r/52930/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-21 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/#review153545
---


Fix it, then Ship it!




Ship It!


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 276)


Could `userGroupInformation` be null here?



ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 285)


Do we need to conditionally get an authenticated connetion if Kerberos is 
not enabled?  Or does `UserGroupInformation.getLoginUser()` behave nicely if no 
Kerberos tickets exists?


- Robert Levas


On Oct. 21, 2016, 10:19 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52930/
> ---
> 
> (Updated Oct. 21, 2016, 10:19 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14384
> https://issues.apache.org/jira/browse/AMBARI-14384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Kerberos enabled cluster
> * SPNEGO enabled on hadoop APIs
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> The same problem appears to be happening on the sinks:
> * 
> ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
> ** No SPNEGO support
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  efa5cba 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
>  3d00270 
> 
> Diff: https://reviews.apache.org/r/52930/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-21 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/
---

(Updated Окт. 21, 2016, 2:19 п.п.)


Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.


Bugs: AMBARI-14384
https://issues.apache.org/jira/browse/AMBARI-14384


Repository: ambari


Description
---

* Kerberos enabled cluster
* SPNEGO enabled on hadoop APIs

/var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
http://metrics-collector:6188/ws/v1/timeline/metrics
2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
server. HTTP Error 401: Authentication required
2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...

The same problem appears to be happening on the sinks:
* 
ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
** No SPNEGO support


Diffs (updated)
-

  ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 efa5cba 
  
ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
 3d00270 

Diff: https://reviews.apache.org/r/52930/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

2016-10-17 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/#review152883
---


Fix it, then Ship it!




Ship It!


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 267)


Missing Javadoc


- Robert Levas


On Oct. 17, 2016, 10:28 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52930/
> ---
> 
> (Updated Oct. 17, 2016, 10:28 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14384
> https://issues.apache.org/jira/browse/AMBARI-14384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Kerberos enabled cluster
> * SPNEGO enabled on hadoop APIs
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> The same problem appears to be happening on the sinks:
> * 
> ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
> ** No SPNEGO support
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  efa5cba 
> 
> Diff: https://reviews.apache.org/r/52930/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>