Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review165585 --- Ship it! Ship It! - Robert Nettleton On Feb. 9, 2017, 11:14

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-09 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review165057 --- Ship it! Ship It! - Sumit Mohanty On Feb. 9, 2017, 11:14

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-09 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/ --- (Updated Feb. 9, 2017, 11:14 p.m.) Review request for Ambari, Alejandro

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Jayush Luniya
> On Feb. 9, 2017, 3:29 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java, > > line 136 > > > > > > Madhu, > > As we discussed,

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review164829 ---

Re: Review Request 56418: Export Blueprints does not contain the settings object and hence the credential store values

2017-02-08 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56418/#review164728 --- Fix it, then Ship it! The code changes in this patch look fine