Re: Review Request 56710: Relax ranger config DB consistency check rules

[Alejandro Fernandez]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.
> 
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to 
> metainfo.xml to Relax on given service for given config-type would be an 
> overkill.
> 
> Jayush Luniya wrote:
> Agreed for 2.5 we should just address this for RANGER in code. I dont 
> think we can make the DB check a warning if some crucial config types are 
> missing. In the long term we can look at a cleaner solution.

Eventually Atlas may need the same thing. I'm ok with it for now then, but we 
should really try to move such definitions to the service metainfo.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Jayush Luniya]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.
> 
> Andrew Onischuk wrote:
> This a one-case scenario. I would say, adding an xml syntax to 
> metainfo.xml to Relax on given service for given config-type would be an 
> overkill.

Agreed for 2.5 we should just address this for RANGER in code. I dont think we 
can make the DB check a warning if some crucial config types are missing. In 
the long term we can look at a cleaner solution.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Andrew Onischuk]

> On Feb. 15, 2017, 9:05 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java,
> >  line 905
> > 
> >
> > We shouldn't be hardcoding service names or config types in a check 
> > like this.
> > If this is preventing the user from starting Ambari Server, then we 
> > should make this type of check be a warning as opposed to a hard error, or 
> > annotate a service or config-type with a tag to relax its validation in 
> > this check.
> > 
> > Please add Jayush to the code review.

This a one-case scenario. I would say, adding an xml syntax to metainfo.xml to 
Relax on given service for given config-type would be an overkill.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---


On Feb. 16, 2017, 11:24 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 16, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/
---

(Updated Feb. 16, 2017, 11:24 a.m.)


Review request for Ambari, Dmitro Lisnichenko and Jayush Luniya.


Bugs: AMBARI-20024
https://issues.apache.org/jira/browse/AMBARI-20024


Repository: ambari


Description (updated)
---

.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 878d0fa 

Diff: https://reviews.apache.org/r/56710/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 56710: Relax ranger config DB consistency check rules

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56710/#review165756
---




ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 (line 905)


We shouldn't be hardcoding service names or config types in a check like 
this.
If this is preventing the user from starting Ambari Server, then we should 
make this type of check be a warning as opposed to a hard error, or annotate a 
service or config-type with a tag to relax its validation in this check.

Please add Jayush to the code review.


- Alejandro Fernandez


On Feb. 15, 2017, 3:13 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56710/
> ---
> 
> (Updated Feb. 15, 2017, 3:13 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20024
> https://issues.apache.org/jira/browse/AMBARI-20024
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  878d0fa 
> 
> Diff: https://reviews.apache.org/r/56710/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>